Continuity of Colors between Conway Operations#57
Merged
Conversation
recursivepaws
marked this pull request as ready for review
July 20, 2026 22:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utilize a new FaceTypeOption struct to keep track of faces as they change.
this enables some extra nuance on coloring that wasn't there before (e.g. Cuboctahedron squares get two different colors based on their symmetries).
it also allows us to keep those faces the same color even when modifications to them modify their side count. (e.g. truncated cube has octagons which match the colors of the original cube).
more work to be done here but this is in a good place for now. i want to use some of this face type reasoning in a reusable way, particularly in the
expandoperation logic and other conway operations as well.