[PHPUnit60] Skip imported PHPUnit assert functions in AddDoesNotPerformAssertionToNonAssertingTestRector - #767
Merged
Conversation
…rmAssertionToNonAssertingTestRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9848
AddDoesNotPerformAssertionToNonAssertingTestRectoronly looked for$this->assert*()method calls andself::assert*()static calls. Assertions called as standalone functions from thePHPUnit\Frameworknamespace were invisible to it, so tests using them were wrongly marked as non-asserting.use PHPUnit\Framework\TestCase; use function PHPUnit\Framework\assertNotNull; final class SomeTest extends TestCase { - #[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions] public function testSomething(): void { assertNotNull(true); } }AssertCallAnalyzernow also treats aFuncCallresolved toPHPUnit\Framework\assert*(and the other known assert prefixes) as an assertion, whether imported viause functionor fully qualified.