Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two related things.
First it allows you to use the
PascalCaseclass name of a rule to find it via the URL. To maintain one consistent canonical URL, this will still redirect to theslugthat it is currently. So:/rule-detail/ArrayToFirstClassCallableRectorwill 301 redirect to/rule-detail/array-to-first-class-callable-rectorThe second thing this adds is an extra convenient way to find rules, which is resolving them via slug or class name at the root of the URL.
This process also redirects to the
/rule-detail/kebab-slugfor a canonical URL, but allows for quickly finding a rector rule from name.So this same rule would be accessible at
https://getrector.com/ArrayToFirstClassCallableRector
and it would redirect to
/rule-detail/array-to-first-class-callable-rectorIf you would like either part of this separately without the other I can split this apart, just let me know.
Thanks!