Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
schema: spec-driven
created: 2026-04-25
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# agent-codex-fix-active-agents-view-container-id-2026-04-25-15-48 (minimal / T1)

Branch: `agent/codex/fix-active-agents-view-container-id-2026-04-25-15-48`

Fix the VS Code Active Agents view container registration. VS Code rejects contributed activity bar container IDs containing dots, so the companion extension must use an alphanumeric/underscore/hyphen-only container ID while preserving the existing `gitguardex.activeAgents` view ID and commands.

Scope:
- Update live and template Active Agents manifests to use `gitguardex-active-agents-container`.
- Update the focus command target to `workbench.view.extension.gitguardex-active-agents-container`.
- Add regression coverage for the container ID character constraint and focus command target.

Verification:
- `node --test test/vscode-active-agents-session-state.test.js`
- Manifest parity check covered by the focused test.

## Handoff

- Handoff: change=`agent-codex-fix-active-agents-view-container-id-2026-04-25-15-48`; branch=`agent/codex/fix-active-agents-view-container-id-2026-04-25-15-48`; scope=`vscode/guardex-active-agents/package.json, templates/vscode/guardex-active-agents/package.json, paired extension.js focus command, test/vscode-active-agents-session-state.test.js`; action=`replace invalid dotted view-container id, verify focused extension test, then finish via PR merge + cleanup`.
- Copy prompt: Continue `agent-codex-fix-active-agents-view-container-id-2026-04-25-15-48` on branch `agent/codex/fix-active-agents-view-container-id-2026-04-25-15-48`. Work inside the existing sandbox, keep live/template VS Code extension files in sync, and when verification is clean run `gx branch finish --branch agent/codex/fix-active-agents-view-container-id-2026-04-25-15-48 --base main --via-pr --wait-for-merge --cleanup`.

## Cleanup

- [ ] Run: `gx branch finish --branch agent/codex/fix-active-agents-view-container-id-2026-04-25-15-48 --base main --via-pr --wait-for-merge --cleanup`
- [ ] Record PR URL + `MERGED` state in the completion handoff.
- [ ] Confirm sandbox worktree is gone (`git worktree list`, `git branch -a`).
2 changes: 1 addition & 1 deletion templates/vscode/guardex-active-agents/extension.js
Original file line number Diff line number Diff line change
Expand Up @@ -3587,7 +3587,7 @@ function activate(context) {
vscode.commands.registerCommand('gitguardex.activeAgents.refresh', refresh),
vscode.commands.registerCommand('gitguardex.activeAgents.restart', restartActiveAgents),
vscode.commands.registerCommand('gitguardex.activeAgents.focus', async () => {
await vscode.commands.executeCommand('workbench.view.extension.gitguardex.activeAgentsContainer');
await vscode.commands.executeCommand('workbench.view.extension.gitguardex-active-agents-container');
}),
vscode.commands.registerCommand('gitguardex.activeAgents.commitSelectedSession', commitSelectedSession),
vscode.commands.registerCommand('gitguardex.activeAgents.openWorktree', async (session) => {
Expand Down
4 changes: 2 additions & 2 deletions templates/vscode/guardex-active-agents/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@
"viewsContainers": {
"activitybar": [
{
"id": "gitguardex.activeAgentsContainer",
"id": "gitguardex-active-agents-container",
"title": "Active Agents",
"icon": "media/active-agents-hivemind.svg"
}
]
},
"views": {
"gitguardex.activeAgentsContainer": [
"gitguardex-active-agents-container": [
{
"id": "gitguardex.activeAgents",
"name": "Active Agents",
Expand Down
7 changes: 4 additions & 3 deletions test/vscode-active-agents-session-state.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1308,13 +1308,14 @@ test('active-agents manifest uses a dedicated activity bar container with a hive
const manifest = readExtensionManifest();
const activitybarContainers = manifest.contributes.viewsContainers?.activitybar || [];
const activeAgentsContainer = activitybarContainers.find(
(entry) => entry.id === 'gitguardex.activeAgentsContainer',
(entry) => entry.id === 'gitguardex-active-agents-container',
);
assert.ok(activeAgentsContainer, 'Expected the Active Agents activity bar container.');
assert.match(activeAgentsContainer.id, /^[A-Za-z0-9_-]+$/);
assert.equal(activeAgentsContainer.title, 'Active Agents');
assert.equal(activeAgentsContainer.icon, 'media/active-agents-hivemind.svg');

const activeAgentsViews = manifest.contributes.views?.['gitguardex.activeAgentsContainer'] || [];
const activeAgentsViews = manifest.contributes.views?.['gitguardex-active-agents-container'] || [];
assert.deepEqual(activeAgentsViews, [
{
id: 'gitguardex.activeAgents',
Expand Down Expand Up @@ -1540,7 +1541,7 @@ test('active-agents focus command opens the dedicated sidebar container', async

assert.equal(
registrations.executedCommands.some((entry) => (
entry.command === 'workbench.view.extension.gitguardex.activeAgentsContainer'
entry.command === 'workbench.view.extension.gitguardex-active-agents-container'
)),
true,
);
Expand Down
2 changes: 1 addition & 1 deletion vscode/guardex-active-agents/extension.js
Original file line number Diff line number Diff line change
Expand Up @@ -3587,7 +3587,7 @@ function activate(context) {
vscode.commands.registerCommand('gitguardex.activeAgents.refresh', refresh),
vscode.commands.registerCommand('gitguardex.activeAgents.restart', restartActiveAgents),
vscode.commands.registerCommand('gitguardex.activeAgents.focus', async () => {
await vscode.commands.executeCommand('workbench.view.extension.gitguardex.activeAgentsContainer');
await vscode.commands.executeCommand('workbench.view.extension.gitguardex-active-agents-container');
}),
vscode.commands.registerCommand('gitguardex.activeAgents.commitSelectedSession', commitSelectedSession),
vscode.commands.registerCommand('gitguardex.activeAgents.openWorktree', async (session) => {
Expand Down
4 changes: 2 additions & 2 deletions vscode/guardex-active-agents/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@
"viewsContainers": {
"activitybar": [
{
"id": "gitguardex.activeAgentsContainer",
"id": "gitguardex-active-agents-container",
"title": "Active Agents",
"icon": "media/active-agents-hivemind.svg"
}
]
},
"views": {
"gitguardex.activeAgentsContainer": [
"gitguardex-active-agents-container": [
{
"id": "gitguardex.activeAgents",
"name": "Active Agents",
Expand Down
Loading