Fix: Cancel and clear downloads. - #3147
Open
ByAyzen wants to merge 4 commits into
Open
Conversation
Collaborator
|
I think this issue should rather be fixed by fixing the core problem which causes downloads to be stuck. This is sadly a bandage solution and I do not want users to accidentally cancel their active downloads. |
Contributor
Author
Agreed. Now it will only delete paused downloads. |
I am reverting these changes because i thought the issue was solved but it didnt fully fix it. Prerelease already had no problem.
Contributor
Author
|
My last commit was unnecessary. I tried to fix some stuck download issue, but apparently it wasn't an issue, it was just for a minute. Prerelease had no problem like that, so I reverted these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix. Fixing this issue #2665