Skip to content

feat: update home banner size and match its shimmer #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iAm-an-iA wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: update home banner size and match its shimmer #3143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f49de0
fix(home): update shimmer with current layout
sdlcspring-glitch Aug 27, 2026
0d080eb
fix(home): Make banner smaller and match its shimmer on TV
iAm-an-iA Aug 28, 2026
e079331
fix(home): match shimmer color
iAm-an-iA Aug 28, 2026
0a0373d
fix(home): revert banner layout
iAm-an-iA Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/src/main/java/com/lagradost/cloudstream3/ui/home/HomeParentItemAdapterPreview.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,9 @@ class HomeParentItemAdapterPreview(
private val previewViewpager: ViewPager2 =
itemView.findViewById(R.id.home_preview_viewpager)

private val homePreviewShimmer: com.facebook.shimmer.ShimmerFrameLayout? =
itemView.findViewById(R.id.home_preview_shimmer)

private val previewViewpagerText: ViewGroup =
itemView.findViewById(R.id.home_preview_viewpager_text)

Expand Down Expand Up @@ -662,6 +665,8 @@ class HomeParentItemAdapterPreview(

when (preview) {
is Resource.Success -> {
homePreviewShimmer?.stopShimmer()
homePreviewShimmer?.isGone = true
previewAdapter.submitList(preview.value.second)
previewAdapter.hasMoreItems = preview.value.first
/*if (!.setItems(
Expand Down Expand Up @@ -693,7 +698,16 @@ class HomeParentItemAdapterPreview(
}
}

is Resource.Loading -> {
previewViewpager.isGone = true
previewViewpagerText.isGone = true
homePreviewShimmer?.isVisible = true
homePreviewShimmer?.startShimmer()
}

else -> {
homePreviewShimmer?.stopShimmer()
homePreviewShimmer?.isGone = true
previewAdapter.submitList(listOf())
previewViewpager.setCurrentItem(0, false)
previewViewpager.isVisible = false
Expand Down
38 changes: 4 additions & 34 deletions app/src/main/res/layout/fragment_home.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_gravity="center"
android:layout_marginTop="15dp"
android:orientation="vertical"
android:paddingTop="40dp"
app:shimmer_auto_start="true"
app:shimmer_base_alpha="0.2"
app:shimmer_duration="@integer/loading_time"
Expand All @@ -40,39 +38,11 @@
android:layout_height="wrap_content"
android:orientation="vertical">

<FrameLayout
<View
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal">

<androidx.cardview.widget.CardView
android:layout_width="125dp"
android:layout_height="200dp"
android:layout_gravity="center"
android:layout_margin="@dimen/loading_margin"
android:background="@color/grayShimmer"
android:translationX="-164dp"
app:cardCornerRadius="@dimen/loading_radius" />

<androidx.cardview.widget.CardView
android:layout_width="148dp"
android:layout_height="234dp"
android:layout_gravity="center"
android:layout_margin="@dimen/loading_margin"
android:background="@color/grayShimmer"
app:cardCornerRadius="@dimen/loading_radius" />

<androidx.cardview.widget.CardView
android:layout_width="125dp"
android:layout_height="200dp"
android:layout_gravity="center"
android:layout_margin="@dimen/loading_margin"
android:background="@color/grayShimmer"
android:translationX="164dp"
app:cardCornerRadius="@dimen/loading_radius" />
</FrameLayout>

<include layout="@layout/loading_line_short_center" />
android:layout_height="500dp"
android:alpha="0.25"
android:background="@color/grayShimmer" />

<LinearLayout
android:layout_width="match_parent"
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/layout/fragment_home_head.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@

</androidx.viewpager2.widget.ViewPager2>

<include layout="@layout/loading_hero_banner" />

<LinearLayout
android:id="@+id/home_padding"
android:layout_width="match_parent"
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/layout/fragment_home_head_tv.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@

</androidx.viewpager2.widget.ViewPager2>

<include layout="@layout/loading_hero_banner" />

<LinearLayout
android:id="@+id/home_preview_viewpager_text"
android:layout_width="match_parent"
Expand Down
46 changes: 9 additions & 37 deletions app/src/main/res/layout/fragment_home_tv.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
android:id="@+id/home_loading"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginStart="@dimen/navbar_width"
android:visibility="gone"
tools:visibility="visible">

Expand All @@ -28,10 +27,8 @@
android:id="@+id/home_loading_shimmer"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_gravity="center"
android:layout_marginTop="15dp"
android:layout_marginTop="60dp"
android:orientation="vertical"
android:paddingTop="40dp"
app:shimmer_auto_start="true"
app:shimmer_base_alpha="0.2"
app:shimmer_duration="@integer/loading_time"
Expand All @@ -42,46 +39,21 @@
android:layout_height="wrap_content"
android:orientation="vertical">

<FrameLayout
<androidx.cardview.widget.CardView
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal">

<androidx.cardview.widget.CardView
android:layout_width="125dp"
android:layout_height="200dp"
android:layout_gravity="center"
android:layout_margin="@dimen/loading_margin"
android:background="@color/grayShimmer"
android:translationX="-164dp"
app:cardCornerRadius="@dimen/loading_radius" />

<androidx.cardview.widget.CardView
android:layout_width="148dp"
android:layout_height="234dp"
android:layout_gravity="center"
android:layout_margin="@dimen/loading_margin"
android:background="@color/grayShimmer"
app:cardCornerRadius="@dimen/loading_radius" />

<androidx.cardview.widget.CardView
android:layout_width="125dp"
android:layout_height="200dp"
android:layout_gravity="center"
android:layout_margin="@dimen/loading_margin"
android:background="@color/grayShimmer"
android:translationX="164dp"
app:cardCornerRadius="@dimen/loading_radius" />
</FrameLayout>

<include layout="@layout/loading_line_short_center" />
android:layout_height="400dp"
android:layout_marginStart="10dp"
android:layout_marginTop="10dp"
android:layout_marginEnd="10dp"
android:alpha="0.25"
app:cardBackgroundColor="@color/grayShimmer"
app:cardCornerRadius="@dimen/rounded_image_radius" />

<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/result_padding"
android:layout_marginTop="@dimen/result_padding"

android:layout_marginEnd="@dimen/result_padding"
android:orientation="vertical">

Expand Down
17 changes: 17 additions & 0 deletions app/src/main/res/layout/loading_hero_banner.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
<com.facebook.shimmer.ShimmerFrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/home_preview_shimmer"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:visibility="gone"
app:shimmer_auto_start="true"
app:shimmer_base_alpha="0.05"
app:shimmer_duration="@integer/loading_time"
app:shimmer_highlight_alpha="0.18">

<View
android:layout_width="match_parent"
android:layout_height="match_parent"
android:background="@color/grayShimmer" />
</com.facebook.shimmer.ShimmerFrameLayout>