Fix T::class in parseJson causing type erasure in some cases#2852
Merged
Conversation
Contributor
Author
|
Was trying to get this update to test it but it wasn't building in my fork or locally so opened here so I can test this for a moment. UPDATE: Tested with both kotlinx serialization and Jackson and it worked now |
Luna712
changed the title
Collaborator
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
Looks good and seems to work well, just some minor nitpicks
fire-light42
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.