Migrate crypto from javax to cryptography-kotlin in library#2813
Migrate crypto from javax to cryptography-kotlin in library#2813Luna712 wants to merge 7 commits into
Conversation
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
These are a lot of changes which are difficult to properly test and would give silent errors if incorrectly ported.
Would it be possible to do some sorts of tests, or anything like that to ensure the migration won't cause regressions?
I'm not sure how to really write reliable tests for this. In order to really write something that would ensure things are proper it would have to be given the right data, and test way more than I really know how to write them for myself. Trying to write tests for some other migrations the best I could but for this one I just didn't really know how unfortunately. |
|
It is outside the scope of this pull request, but the extractors themselves could be tested with mock data 🤔 |
|
Do not worry about the tests, I will try to test them manually before merging. |
|
Sounds great thanks a lot! |
2 participants
No description provided.