Skip to content

Remove checking unsupported SDK versions#2603

Closed
Luna712 wants to merge 1 commit intorecloudstream:masterfrom
Luna712:remove-sdk-checks
Closed

Remove checking unsupported SDK versions#2603
Luna712 wants to merge 1 commit intorecloudstream:masterfrom
Luna712:remove-sdk-checks

Conversation

@Luna712
Copy link
Copy Markdown
Contributor

@Luna712 Luna712 commented Apr 3, 2026

No description provided.

@fire-light42
Copy link
Copy Markdown
Collaborator

This is some very good thinking and it makes sense. However, I want to keep these redundant checks for the sole purpose of making the life easier for any ambitious programmers who want to fork CloudStream to support Android 5 again. I understand that the reasoning is a bit backwards.

I did not expect anyone to notice the issue and make a fix for it and therefore I never clarified my opinions on this point. It is very unfortunate to reject your good work due to this.

@Luna712
Copy link
Copy Markdown
Contributor Author

Luna712 commented Apr 3, 2026

This is some very good thinking and it makes sense. However, I want to keep these redundant checks for the sole purpose of making the life easier for any ambitious programmers who want to fork CloudStream to support Android 5 again. I understand that the reasoning is a bit backwards.

I did not expect anyone to notice the issue and make a fix for it and therefore I never clarified my opinions on this point. It is very unfortunate to reject your good work due to this.

@fire-light42

I do understand that however I dont find it a valid point personally, though that is fine. Forking cloudstream to support A5 already requires forking the commit just before minsdk bump as the media3 bump (and all androidx library bumps for that matter) and the changes to all the overwritten media3 classes require significant work to undo to the point that you may as well just fork right before minsdk was bumped. Additionally anything in the future would not be guaranteed to add checks for it since lint no longer warns on it with bumped minsdk.

Nonetheless, I absolutely respect your decision on this. Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants