net: FeeFilter min_relay is atomic, not inner.read - #321
Merged
Conversation
Tip-follow handshake called min_relay_sat_kvb() on the session, which took a blocking mempool inner read. After #320's assert_not_reactor that panicked tokio-rt-worker and left follow_live=0. Overlay lives on an AtomicU64. rebroadcast_unbroadcast uses try_contains so blocksonly re-INV does not park either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainnet.log after #320: three
tokio-rt-workerpanics at tip-mode entry:Handshake sends
FeeFilterviaMempoolHub::min_relay_sat_kvb(), which still took a blockinginnerread. IBD skips FeeFilter (relay off); tip-mode does not. Panic aborts the session task →follow_live=0, no INV/getdata/accepts, process still printstip: perf.What
-minrelaytxfeeoverlay is anAtomicU64. Session FeeFilter does not touchinner.rebroadcast_unbroadcastusestry_contains(same class: session afteraccept_tx_asyncwhen relay is off).min_relay_sat_kvb_does_not_panic_on_tokio_worker,rebroadcast_unbroadcast_does_not_panic_on_tokio_worker.Lock facts stay in
docs/concurrency.md.Do not merge unless asked.