store: do not clear leftover hop-dump on the next resolve batch - #318
Merged
Conversation
clear_leftover_miss ran at the start of every TipOnly/leftover resolve and wiped LAST_PROBE_DIAG. Parallel cargo test then failed leftover_miss_dumps_probe_diag (ready flag already gone). The operator reject line could also lose diag=1. Miss classification stays per-batch; the hop-dump is consumed by take() only. Pin this parent via a short recorded-txid ring so the query test does not depend on a process flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Master
ci/testafter #316 failed onarchive::tests::leftover_miss_dumps_probe_diag(leftover miss must hop-dump once).clear_leftover_missruns at the start of every TipOnly/leftoverget_fk_by_txid_batch. It also wipedLAST_PROBE_DIAG. Parallel tests then sawleftover_probe_diag_ready() == falseafter a real leftover dump. The operator reject line (diag=1) could lose the same dump.Fix
take_leftover_probe_diag.Does not merge #317 (IBD tick cadence).