Fixes #5666#5670
Conversation
…ealm-gradle-plugin to keep it consistent with rootProject.name delcared in settings.gradle
cmelchior
left a comment
cmelchior
left a comment
There was a problem hiding this comment.
Thanks for fixing this. We can unfortunately not merge the PR as it is, as it is a breaking change, but if you redirect it to next-major instead we can merge it there. We also need to update the CHANGELOG with the minimum version supported after this. I believe it is 2.2 or 2.3 right where annotationProcessor was added?
| # Cmake output | ||
| realm/realm-library/.externalNativeBuild | ||
|
|
||
| gen/ |
There was a problem hiding this comment.
Where do these come from?
There was a problem hiding this comment.
Last time I saw gen it came from Eclipse things. 😮
There was a problem hiding this comment.
@cmelchior @Zhuinden I am not sure from where It came, I have imported the whole project in IntelliJ Ultimate, and i guess the build generated the gen folder so I have added it in the .gitignore, to ignore then gen folder.
| @@ -42,30 +41,17 @@ class Realm implements Plugin<Project> { | |||
|
|
|||
| def syncEnabledDefault = false | |||
| def dependencyConfigurationName = getDependencyConfigurationName(project) | |||
| def usesAptPlugin = project.plugins.findPlugin('com.neenbedankt.android-apt') != null | |||
There was a problem hiding this comment.
While I think we can remove support for this, we cannot do it in a patch release as it might be a breaking change, but if you direct this PR towards the branch next-major instead then it should be fine 👍
There was a problem hiding this comment.
(although technically AS 3.0 cannot run android-apt anymore, but maybe some legacy projects still use it with older version of IDE)
There was a problem hiding this comment.
@cmelchior I have changed the branch to next-major :)
| dependencies { | ||
| implementation project(':realm-library') | ||
| implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version" | ||
| implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" |
There was a problem hiding this comment.
I'm not entirely sure what impact this has on downstream projects?
4 participants
Renamed directory to realm-gradle-plugin to keep it consistent with realm-gradle-plugin.
Removed Android APT Plugin and some minor refactors.
Added gen/ and /out to gitignore
Fixes #5666