Skip to content

Supports OkBuck build#4133

Open
zaki50 wants to merge 1 commit intomainfrom
my/support_okbuck
Open

Supports OkBuck build#4133
zaki50 wants to merge 1 commit intomainfrom
my/support_okbuck

Conversation

@zaki50
Copy link
Copy Markdown
Contributor

@zaki50 zaki50 commented Feb 1, 2017

add a constructor to RealmTransformer which takes file path of configuration in order to support OkBuck

fixes #3971

TODOs

  • removing dependency to gradle from RealmTransformer
  • added a constructor for OkBuck to RealmTransformer
  • changeling
  • need to solve the error OkBuck support #3971 (comment)

@zaki50
Copy link
Copy Markdown
Contributor Author

zaki50 commented Feb 1, 2017

There seems to be a problem in OkBuck.
#3971 (comment)

Build with OkBuck currently fails.

@kageiit
Copy link
Copy Markdown
Contributor

kageiit commented Feb 1, 2017

@malbano would you like to chime in on this?

@kageiit kageiit mentioned this pull request Feb 1, 2017

@Override
List<String> getBootClassPathList() {
return bootClassPathList
Copy link
Copy Markdown

@malbano malbano Feb 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boot classpaths are already passed in the transform invocation as referenced input jar, so you just need to add those to your class loader.

// constructor for OkBuck
public RealmTransformer(File configFile) {
if (!configFile.exists()) {
throw new FileNotFoundException(configFile.absolutePath)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can expect this to always exist. Transform-cli does that check if a config file is specified: uber/okbuck@ebcea6f#diff-10fc19e7dd1e6127839942575e0a0ba1R59

@cmelchior
Copy link
Copy Markdown
Contributor

cmelchior commented Feb 3, 2017

@zaki50 I created https://github.com/realm/realm-java/tree/cm/okbuck-example to have an example we could point to in the repo, but ran into uber/okbuck#380 and uber/okbuck#381

@kageiit
Copy link
Copy Markdown
Contributor

kageiit commented Feb 3, 2017

@cmelchior @zaki50 I posted the configuration fix in uber/okbuck#380 (comment)

The setup currently for the example is not correctly configured

@Zhuinden
Copy link
Copy Markdown
Contributor

Zhuinden commented Jun 28, 2017

Any luck with this? Or maybe when the RealmTransformer becomes Kotlin? :D

@meierjan
Copy link
Copy Markdown

any progress?

@cmelchior
Copy link
Copy Markdown
Contributor

Hi @meierjan Unfortunately not. We ran into some issues and figuring a way around those doesn't have a high priority right now.

@Zhuinden
Copy link
Copy Markdown
Contributor

Zhuinden commented Aug 31, 2017

@meierjan (the current priority is preparing for RMP 2.0 scheduled for the end of September October, bringing in new features like primitive list support)

Also if I gathered it right, the problem is that OkBuck can execute transform task only if it is written with non-Groovy things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OkBuck support

8 participants