Bug fixes and cleanup of account password and in-game server browser filtering code#4
Open
gavrant wants to merge 2 commits intorealitymod:masterfrom
Open
Bug fixes and cleanup of account password and in-game server browser filtering code#4gavrant wants to merge 2 commits intorealitymod:masterfrom
gavrant wants to merge 2 commits intorealitymod:masterfrom
Conversation
+ general cleanup of C artifacts in password encoder and decoder + added checks for too short or too long (exceeding the vBF2 limit of 30 characters) passwords, with relevant client error messages
- Fixed filters ending with ")gametype like '%gpm_cq%'" not being properly "and"-fixed - Fixed "like" strings being broken on "and" fixing if they contain a GameServer property name (for example, '%country%') - Fixed "and" fixing breaking a filter if a GameServer property name is mentioned more than once in the filter (for example, hostname like '%country%' and mapname like '%country%') - On any parsing syntax exception return an empty server list to the client - General streamlining of the filter parser/fixer code, with better handling of unescaped BF2 filter like-strings (I dare say)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the fixed issues I've seen in error logs while running a live clone of PRMasterServer for another BF2 mod, others surfaced during testing.
Note that the top limit of password length of 30 characters I use in LoginServerMessages.cs, NewUser came from the vBF2 client and may not fit to Project Reality.