fix: allow parsing empty callouts like > without breaking
#1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- defaults to the mdx behaviour
…to falco/cx-2520-the-symbol-in-the-description-breaks-the-rendering
…to falco/cx-2520-the-symbol-in-the-description-breaks-the-rendering
eaglethrost
reviewed
Jan 15, 2026
| visit(tree, 'blockquote', (node: Blockquote) => { | ||
| if (!(node.children[0].type === 'paragraph' && node.children[0].children[0].type === 'text')) return; | ||
| visit(tree, 'blockquote', (node: Blockquote, index: number | undefined, parent: Parent | undefined) => { | ||
| if (!isCalloutStructure(node)) { |
Contributor
There was a problem hiding this comment.
Can you move this check and the code inside it to its own function, on top of this file? I think it would improve readability
eaglethrost
reviewed
Jan 15, 2026
|
|
||
| // For 'mdx' format (or undefined): leave empty blockquotes as-is (can be rendered as empty callout) | ||
| // For 'md' format: always replace non-callout blockquotes with stringified content | ||
| if (format !== 'md' && isEmpty) { |
Contributor
There was a problem hiding this comment.
If it's not md but it's not empty, do we still want to stringify the content?
Contributor
|
I think it would be good to add a test to render the Callout and make sure it doesn't break the UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Adds a format option to
calloutTransformerin bothmdxandmdxishto control empty blockquote handling:format === 'md', empty blockquotes are replaced with paragraphs containing the stringified content ('>')format === 'mdx'(or undefined) they remain as blockquotes to allow rendering as empty callouts.This fixes errors when processing standalone '>' in MD format and preserves empty callout rendering in MDX. Includes tests for both formats in the transformer, MDX serialization, and mdxish processing pipelines.
The main reason the logic is split between these formats is because the excerpt component in the page headers uses the MD format while the body uses the MDX format. This done to allow cases like this:
🧬 QA & Testing