Skip to content

Contact form: a sendmail that exits before reading it all has not sent it #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamjohnwright merged 1 commit into from
Oct 21, 2026
Merged

Contact form: a sendmail that exits before reading it all has not sent it #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions projects/website-angular/src/scripts/contact-route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,13 @@ function sendmail(raw, from, sendmailPath = '/usr/sbin/sendmail', timeoutMs = 30
child.on('error', fail);
child.on('close', (code) => {
clearTimeout(timer);
if (code === 0) resolve();
else reject(new Error(`sendmail exited ${code}: ${stderr.trim()}`));
// Sent only when it was also all read: a sendmail that exits 0 before
// reading the whole message has not sent it, and whether its EPIPE or
// its exit is heard first is a race.
if (code !== 0) reject(new Error(`sendmail exited ${code}: ${stderr.trim()}`));
else if (!child.stdin.writableFinished)
reject(new Error('sendmail exited before reading the whole message'));
else resolve();
});
// Unheard, a sendmail that exits before reading all of this (EPIPE) would
// be an uncaught error, and take the whole server down with it.
Expand Down
Loading