Skip to content

⚡ perf: use reduce instead of filter().map() in realtime-metrics #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunnylqm merged 1 commit into from
Mar 5, 2026
Merged

⚡ perf: use reduce instead of filter().map() in realtime-metrics #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/pages/realtime-metrics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,18 @@ export const Component = () => {
const isAdmin = user?.admin === true;

const appOptions = useMemo(() => {
return (apps || [])
.filter((app) => !!app.appKey)
.map((app) => ({
label: app.name,
value: app.appKey as string,
}));
return (apps || []).reduce<{ label: string; value: string }[]>(
(acc, app) => {
if (app.appKey) {
acc.push({
label: app.name,
value: app.appKey as string,
});
}
return acc;
},
[],
);
}, [apps]);

// Sync URL param to state on mount or URL change
Expand Down