feat: add for support AOT request routing#2182
Closed
TimothyMakkison wants to merge 19 commits into
Closed
Conversation
Collaborator
Author
TestsNeed to look into writing more tests, especially generated tests to ensure that exception generation and the unmatched route are emitted. Failing tests
Tempted to try and add Query support in the same PR, happy to make a follow up Pr otherwise. |
Contributor
|
Hows this related to the work in #2174 |
5 tasks
Member
|
@TimothyMakkison check the Slack messages :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AOT support for request routing
ICustomAttributeProviderby cachingParameterInfoandPropertyInfolookups in aConcurrentDictionaryConcurrentDictionaryRestMethodInfoInternaland emitting logic is based uponRequestBuilderImplementation.RequestBuildingValueStringBuildercallsHaven't added tests or cleaned up yet, would like to hear feed back before doing anything more.
ValueStringbuilderis currently public, I suspect it could be emitted once withininternal partial class GeneratedNote that the above code could probably be simplified with
CalledMemberNameandnameof