Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow invoked
git-release-noteswithout a head ref, so it resolved the head itself instead of being pinned to the commit actually being published. On a release run this can produce release notes for a different commit than the one packaged and tagged.Change
--head-ref "$env:GITHUB_SHA"togit-release-notesin.github/workflows/release.ymlso the notes are always generated from the exact commit being published..github/scripts/Test-ReleaseNotesInvocation.ps1, which validates thegit-release-notescommand contract (that the workflow invocation supplies the expected arguments) so a future edit that drops--head-reffails fast..github/workflows/release.ymland.github/workflows/ci-build.yml, extending the existing workflow command-contract validation already performed in CI.Fixes #1180