Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy
TransformSafeAsyncoverloads forwarded their arguments to the newer implementation without validating them first, so a nulltransformFactoryorerrorHandlersurfaced later (or not at all) instead of failing at the call site.This adds eager argument validation to those overloads so a null factory or error handler throws
ArgumentNullExceptionimmediately, matching the behavior of the rest of the cache operator surface. Tests cover the null-argument cases for the affected overloads.Focused validation for this change passed prior to submission.
Fixes #1183