Avoid invalid errata enum values in tests (#2034) - #2034
Merged
Merged
Conversation
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122761729. |
meta-codesync
Bot
changed the title
cipolleschi
added a commit
to cipolleschi/yoga
that referenced
this pull request
Oct 1, 2026
Summary: Replace bitwise complements of the unscoped YGErrata enum with masks derived from YGErrataAll. The complement sets high bits outside the enum's valid range and makes the sanitizer-enabled yoga-github-first-compatibility workflow fail, even though the intended operation is only to clear one known errata bit. This preserves the existing test behavior without changing Yoga's public API or ABI. Differential Revision: D122761729
cipolleschi
force-pushed
the
export-D122761729
branch
from
October 1, 2026 10:52
41b77ae to
ec0fe85
Compare
Summary: Pull Request resolved: react#2034 Replace bitwise complements of the unscoped YGErrata enum with masks derived from YGErrataAll. The complement sets high bits outside the enum's valid range and makes the sanitizer-enabled yoga-github-first-compatibility workflow fail, even though the intended operation is only to clear one known errata bit. This preserves the existing test behavior without changing Yoga's public API or ABI. Differential Revision: D122761729
cipolleschi
force-pushed
the
export-D122761729
branch
from
October 1, 2026 10:57
ec0fe85 to
17b7fc8
Compare
cortinico
approved these changes
Oct 1, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace bitwise complements of the unscoped YGErrata enum with masks derived from YGErrataAll. The complement sets high bits outside the enum's valid range and makes the sanitizer-enabled yoga-github-first-compatibility workflow fail, even though the intended operation is only to clear one known errata bit. This preserves the existing test behavior without changing Yoga's public API or ABI.
Differential Revision: D122761729