Skip to content

Remove loadCommunityMiddleware from community-cli-plugin #59665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntie wants to merge 1 commit into from
+2 −66
Open

Remove loadCommunityMiddleware from community-cli-plugin #59665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions packages/community-cli-plugin/src/dev-server/loadCommunityMiddleware.js
View file
Open in desktop

This file was deleted.

17 changes: 1 addition & 16 deletions packages/community-cli-plugin/src/dev-server/runDevServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import attachKeyHandlers from './attachKeyHandlers';
import createDevMiddlewareLogger from './createDevMiddlewareLogger';
import createDevServerMiddleware from './createDevServerMiddleware';
import isDevServerRunning from './isDevServerRunning';
import loadCommunityMiddleware from './loadCommunityMiddleware';
import * as version from './version';
import {createDevMiddleware} from '@react-native/dev-middleware';
import * as Metro from 'metro';
Expand Down Expand Up @@ -107,15 +106,6 @@ async function runDevServer(
const ReporterImpl = getReporterImpl(args.customLogReporterPath);
const terminalReporter = new ReporterImpl(terminal);

const createCommunityMiddleware = loadCommunityMiddleware();
const {
middleware: communityMiddleware,
websocketEndpoints: communityWebsocketEndpoints,
} = createCommunityMiddleware({
host: hostname,
port,
watchFolders,
});
const logger = createDevMiddlewareLogger(terminalReporter);
const {middleware, websocketEndpoints} = createDevMiddleware({
serverBaseUrl: devServerUrl,
Expand Down Expand Up @@ -159,13 +149,8 @@ async function runDevServer(
secure: args.https,
secureCert: args.cert,
secureKey: args.key,
unstable_extraMiddleware: [
pluginMiddleware,
communityMiddleware,
middleware,
],
unstable_extraMiddleware: [pluginMiddleware, middleware],
websocketEndpoints: {
...communityWebsocketEndpoints,
...pluginWebsocketEndpoints,
...websocketEndpoints,
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/React/DevSupport/__docs__/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Each step is described in its own document:
| -------------------------- | ------------------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `GET /status` | `RCTBundleURLProvider` | Is Metro running |
| `GET /<root>.bundle?…` | `RCTJavaScriptLoader` | Bundle download |
| `GET /<root>/<name>.<ext>` | `RCTBundleURLProvider` resource URLs | Native resources |
| `GET /<root>/<name>.<ext>` | `RCTBundleURLProvider` resource URLs | Project file by path; not served by `react-native start` |
| WS `/message?role=ios` | `RCTPackagerConnection` | Reload, Dev Menu, custom |
| WS `/hot` | `HMRClient.js` | Fast Refresh |
| WS `/inspector/device?…` | `RCTCxxInspectorPackagerConnection` | React Native DevTools |
Expand Down
Loading