Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127611314. |
Visual regressionNo visual differences at ios: no capture |
meta-codesync
Bot
changed the title
zeyap
pushed a commit
to zeyap/react-native
that referenced
this pull request
Oct 28, 2026
Summary: Android `SafeAreaView` ignored the `pointerEvents` prop, so a `SafeAreaView` with `pointerEvents="box-none"` still caught touches outside its children instead of passing them to the views underneath. `ReactSafeAreaView` now implements `ReactPointerEventsView` and `ReactSafeAreaViewManager` applies `pointerEvents` in `updateProperties`. Without the prop it stays `AUTO`, so existing behavior is unchanged. Changelog: [Android][Fixed] - SafeAreaView now respects pointerEvents Reviewed By: zeyap Differential Revision: D127611314
zeyap
force-pushed
the
export-D127611314
branch
from
October 28, 2026 18:12
6e88494 to
f5ad69d
Compare
zeyap
pushed a commit
to zeyap/react-native
that referenced
this pull request
Oct 28, 2026
Summary: Android `SafeAreaView` ignored the `pointerEvents` prop, so a `SafeAreaView` with `pointerEvents="box-none"` still caught touches outside its children instead of passing them to the views underneath. `ReactSafeAreaView` now implements `ReactPointerEventsView` and `ReactSafeAreaViewManager` applies `pointerEvents` in `updateProperties`. Without the prop it stays `AUTO`, so existing behavior is unchanged. Changelog: [Android][Fixed] - SafeAreaView now respects pointerEvents Reviewed By: zeyap Differential Revision: D127611314
zeyap
force-pushed
the
export-D127611314
branch
from
October 28, 2026 21:12
f5ad69d to
b3ba156
Compare
zeyap
pushed a commit
to zeyap/react-native
that referenced
this pull request
Oct 29, 2026
Summary: Android `SafeAreaView` ignored the `pointerEvents` prop, so a `SafeAreaView` with `pointerEvents="box-none"` still caught touches outside its children instead of passing them to the views underneath. `ReactSafeAreaView` now implements `ReactPointerEventsView` and `ReactSafeAreaViewManager` applies `pointerEvents` in `updateProperties`. Without the prop it stays `AUTO`, so existing behavior is unchanged. Changelog: [Android][Fixed] - SafeAreaView now respects pointerEvents Reviewed By: zeyap Differential Revision: D127611314
zeyap
force-pushed
the
export-D127611314
branch
from
October 29, 2026 05:30
b3ba156 to
d8eb861
Compare
javache
requested changes
Oct 29, 2026
javache
left a comment
javache
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
javache
approved these changes
Oct 29, 2026
javache
left a comment
javache
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: Android `SafeAreaView` ignored the `pointerEvents` prop, so a `SafeAreaView` with `pointerEvents="box-none"` still caught touches outside its children instead of passing them to the views underneath. The `SafeAreaView` native component spec now declares `pointerEvents`, so the generated `SafeAreaViewManagerDelegate` passes it to `ReactSafeAreaViewManager.setPointerEvents`, and `ReactSafeAreaView` implements `ReactPointerEventsView`. Without the prop it stays `AUTO`, so existing behavior is unchanged. Changelog: [Android][Fixed] - SafeAreaView now respects pointerEvents Reviewed By: zeyap, javache Differential Revision: D127611314
zeyap
force-pushed
the
export-D127611314
branch
from
October 29, 2026 14:28
d8eb861 to
f26ef8a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Android
SafeAreaViewignored thepointerEventsprop, so aSafeAreaViewwithpointerEvents="box-none"still caught touches outside its children instead of passing them to the views underneath.The
SafeAreaViewnative component spec now declarespointerEvents, so the generatedSafeAreaViewManagerDelegatepasses it toReactSafeAreaViewManager.setPointerEvents, andReactSafeAreaViewimplementsReactPointerEventsView. Without the prop it staysAUTO, so existing behavior is unchanged.Changelog:
[Android][Fixed] - SafeAreaView now respects pointerEvents
Reviewed By: zeyap, javache
Differential Revision: D127611314