Repository navigation
Fix iOS borderCurve: 'continuous' for Fabric views when not all corners are rounded - #59566
Open
levibuzolic wants to merge 2 commits into
Open
levibuzolic wants to merge 2 commits into
levibuzolic wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On iOS Fabric views,
borderCurve: 'continuous'is ignored when only some corners are rounded. For example:These views use circular CGPaths for their backgrounds and clipping masks, so they render circular corners. Uniform-radius views already use Core Animation’s continuous curves.
This change uses a native
CALayermask withcornerCurve,cornerRadius, andmaskedCornerswhen the rounded corners share one radius. It updates background, content, image, and padding-box masks.The existing circular path fallback is still used for unequal radii and radii exceeding half the mask's shorter dimension.
Changelog:
[IOS] [FIXED] - Fix
borderCurve: 'continuous'for Fabric view backgrounds and clipping masks when not all corners are rounded.Test Plan:
Added four visual tests covering circular and continuous for:
Local validation:
Screenshots
These screenshots show a
borderCurve: 'continuous'(blue) overlayed on top of aborderCurve: 'circular'(red) view to show the difference. The red bleeding through is the desired outcome showing that thecontinuoussetting is being applied to the blue view.