Repository navigation
Scroll SectionList viewability E2E to its target deterministically - #59563
Open
christophpurrer wants to merge 1 commit into
Open
christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
Summary: Replace the Maestro swipe in `sectionlist-viewability.yml` with taps on a new example button that calls `scrollToLocation` centered on Cheesecake plus `recordInteraction`. Maestro stops swiping at the first offset it deems fully visible, which React Native can measure as less than 100% coverage, so the output assertion times out. Changelog: [Internal] Differential Revision: D127948384
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127948384. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…eact#59563) Summary: Replace the Maestro swipe in `sectionlist-viewability.yml` with taps on a new example button that calls `scrollToLocation` centered on Cheesecake plus `recordInteraction`. Maestro stops swiping at the first offset it deems fully visible, which React Native can measure as less than 100% coverage, so the output assertion times out. Changelog: [Internal] Differential Revision: D127948384
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…eact#59563) Summary: Replace the Maestro swipe in `sectionlist-viewability.yml` with taps on a new example button that calls `scrollToLocation` centered on Cheesecake plus `recordInteraction`. Maestro stops swiping at the first offset it deems fully visible, which React Native can measure as less than 100% coverage, so the output assertion times out. Changelog: [Internal] Differential Revision: D127948384
Visual regression1 visual difference(s) at android: no capture ios
|
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…eact#59563) Summary: Replace the Maestro swipe in `sectionlist-viewability.yml` with taps on a new example button that calls `scrollToLocation` centered on Cheesecake plus `recordInteraction`. Maestro stops swiping at the first offset it deems fully visible, which React Native can measure as less than 100% coverage, so the output assertion times out. Changelog: [Internal] Differential Revision: D127948384
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary:
Replace the Maestro swipe in
sectionlist-viewability.ymlwith taps on a new example button that callsscrollToLocationcentered on Cheesecake plusrecordInteraction. Maestro stops swiping at the first offset it deems fully visible, which React Native can measure as less than 100% coverage, so the output assertion times out.Changelog: [Internal]
Differential Revision: D127948384