Repository navigation
Prepare native ScrollView safe area content padding - #59528
Open
cipolleschi wants to merge 1 commit into
Open
cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
Summary: Keep the requested content inset separate from UIKit's safe area correction and add native support for `padsContentForSafeArea`, defaulting to false. Existing JavaScript retains the current inset behaviour. The follow-up enables the correction together with content-container padding. Changelog: [Internal] Differential Revision: D127790579
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127790579. |
Visual regression1 visual difference(s) at ios
|
| Expected | Captured |
|---|---|
 |
 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Keep the requested content inset separate from UIKit's safe area correction and add native support for
padsContentForSafeArea, defaulting to false. Existing JavaScript retains the current inset behaviour. The follow-up enables the correction together with content-container padding.Changelog: [Internal]
Differential Revision: D127790579