Skip to content

Share iOS text measurements that differ only in unused constraints #59527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hryhoriiK97 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Share iOS text measurements that differ only in unused constraints #59527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...erer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/TextLayoutManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#import "TextLayoutManager.h"
#import "RCTTextLayoutManager.h"

#import <limits>
#import <optional>

#import <react/renderer/attributedstring/PlaceholderAttributedString.h>
Expand Down Expand Up @@ -53,10 +54,15 @@
const auto &attributedString =
placeholderAttributedString ? *placeholderAttributedString : originalAttributedString;

// The native measurement depends only on the maximum width, and the result is clamped to the
// full constraints below, outside the cache, so the rest is left out of the key.
LayoutConstraints keyConstraints = layoutConstraints;
keyConstraints.minimumSize = Size{};
keyConstraints.maximumSize.height = std::numeric_limits<Float>::infinity();
measurement = textMeasureCache_.get(
{.attributedString = attributedString,
.paragraphAttributes = paragraphAttributes,
.layoutConstraints = layoutConstraints,
.layoutConstraints = keyConstraints,
.pointScaleFactor = layoutContext.pointScaleFactor},
[&]() {
auto telemetry = TransactionTelemetry::threadLocalTelemetry();
Expand Down
Loading