Repository navigation
Settle RNTester before sending visual deep link - #59518
Closed
christophpurrer wants to merge 1 commit into
Closed
christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
Summary: Visual capture deep-links each example immediately after relaunching RNTester. On a slow emulator the JS Linking listener is not registered yet, so the link is dropped and every example assertion fails. Settle the UI, link, settle again, then link again: the second send lands after subscription and re-sending is a no-op. Settle waits never fail, tolerating restore to another screen. Changelog: [Internal] Differential Revision: D127624232
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127624232. |
|
This pull request has been merged in 60de64e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Visual capture deep-links each example immediately after relaunching RNTester. On a slow emulator the JS Linking listener is not registered yet, so the link is dropped and every example assertion fails. Settle the UI, link, settle again, then link again: the second send lands after subscription and re-sending is a no-op. Settle waits never fail, tolerating restore to another screen.
Changelog: [Internal]
Differential Revision: D127624232