Repository navigation
Delete never-posted RCTBridge notifications (#59437) - #59437
Open
christophpurrer wants to merge 8 commits into
Open
christophpurrer wants to merge 8 commits into
christophpurrer wants to merge 8 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127294776. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete them with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep `RCTBridgeWillReloadNotification`, still observed by Expo, and mark it deprecated. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and invalidation notifications Differential Revision: D127294776
christophpurrer
force-pushed
the
export-D127294776
branch
from
October 24, 2026 03:11
1720026 to
fed4ca7
Compare
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete them with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep `RCTBridgeWillReloadNotification`, still observed by Expo, and mark it deprecated. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and invalidation notifications Differential Revision: D127294776
christophpurrer
force-pushed
the
export-D127294776
branch
2 times, most recently
from
October 27, 2026 14:16
96e053c to
f1e2819
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete them with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep `RCTBridgeWillReloadNotification`, still observed by Expo, and mark it deprecated. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and invalidation notifications Differential Revision: D127294776
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Differential Revision: D127294776
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Differential Revision: D127294776
christophpurrer
force-pushed
the
export-D127294776
branch
from
October 27, 2026 18:42
f1e2819 to
c5f5be7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Reviewed By: vzaidman Differential Revision: D127294776
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Differential Revision: D127294776
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Differential Revision: D127294776
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Reviewed By: vzaidman Differential Revision: D127294776
christophpurrer
force-pushed
the
export-D127294776
branch
from
October 27, 2026 22:24
c5f5be7 to
3c22ce4
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Reviewed By: vzaidman Differential Revision: D127294776
christophpurrer
force-pushed
the
export-D127294776
branch
from
October 27, 2026 23:16
3c22ce4 to
255b99a
Compare
Visual regressionNo visual differences at android: no capture |
Summary: The C++ bridge delegate protocol has no implementers left: its only method served the removed `RCTCxxBridge`. Delete the header with its build entry, the stale forward declaration, and the unused imports. Changelog: [iOS][Removed] - Remove unused `RCTCxxBridgeDelegate` protocol Differential Revision: D127294781
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Differential Revision: D127294783
Summary: Remove `RCTBridge` declarations with zero callers: `enqueueJSCall`, module lookup, `delegate`, `moduleClasses`, reload, and batch APIs, plus their stub implementations. Keep `bundleURL`, still read by Expo Dev Menu, and the TurboModule-registry hooks the proxy forwards through, all marked deprecated. Delete skipped `RCTLoggingTests`, the only `enqueueJSCall` caller. Changelog: [iOS][Removed] - Remove unused `RCTBridge` reload, module-lookup, and JS-callback APIs [iOS][Deprecated] - Deprecate `RCTBridge.bundleURL`, `setRCTTurboModuleRegistry:`, and `bridgeModuleDecorator` Differential Revision: D127265582
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
Summary: Both `RCTBridge` initializers return an inert stub and have no callers left now that the test harness is gone. Delete the declarations and stub implementations. `RCTBridgeModuleListProvider` stays until the proxy shim using it is removed. Changelog: [iOS][Removed] - Remove deprecated `RCTBridge` initializers Differential Revision: D127294773
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
Summary: The `RCTBridge (Inspector)` category exposes `inspectorTarget`/`inspectable` with zero callers; the modern inspector reaches `RCTHost` directly. Delete the header, its buck entry, the unused imports, and the proxy shim. Changelog: [iOS][Removed] - Remove unused `RCTBridge (Inspector)` category Differential Revision: D127294775
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Differential Revision: D127294776
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Reviewed By: vzaidman Differential Revision: D127294776
christophpurrer
force-pushed
the
export-D127294776
branch
from
October 28, 2026 14:49
255b99a to
780d5c8
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Differential Revision: D127294776
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Reviewed By: vzaidman Differential Revision: D127294776
christophpurrer
force-pushed
the
export-D127294776
branch
from
October 28, 2026 15:20
780d5c8 to
0d5bd63
Compare
Summary: Pull Request resolved: react#59437 Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications, `WillBeInvalidated`, and the keys with the dead observers in `RCTDeviceInfo`, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along with `WillReload`. Changelog: [iOS][Removed] - Remove never-posted `RCTBridge` script-download and `WillBeInvalidated` notifications [iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated Reviewed By: vzaidman Differential Revision: D127294776
christophpurrer
force-pushed
the
export-D127294776
branch
from
October 28, 2026 15:25
0d5bd63 to
2d2ab63
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Five bridge notifications and three user-info keys have zero posters; only fast refresh is posted and observed. Delete the script-download notifications,
WillBeInvalidated, and the keys with the dead observers inRCTDeviceInfo, the avatar updates module, and both reload perf loggers. Keep the two invalidation notifications Skia and Reanimated still observe, marked deprecated along withWillReload.Changelog:
[iOS][Removed] - Remove never-posted
RCTBridgescript-download andWillBeInvalidatednotifications[iOS][Deprecated] - Deprecate never-posted invalidation notifications still observed by Skia and Reanimated
Reviewed By: vzaidman
Differential Revision: D127294776