Repository navigation
Delete stub RCTAppSetupDefaultJsExecutorFactory (#59435) - #59435
Open
christophpurrer wants to merge 6 commits into
Open
christophpurrer wants to merge 6 commits into
christophpurrer wants to merge 6 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127294774. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D127294774
branch
from
October 24, 2026 03:05
4c047cb to
e65b841
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
christophpurrer
force-pushed
the
export-D127294774
branch
from
October 24, 2026 03:11
e65b841 to
7e7212d
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
christophpurrer
force-pushed
the
export-D127294774
branch
from
October 24, 2026 03:23
7e7212d to
1f311cf
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
christophpurrer
force-pushed
the
export-D127294774
branch
from
October 27, 2026 14:18
1f311cf to
b13fe0f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
Visual regressionNo visual differences at |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294774
christophpurrer
force-pushed
the
export-D127294774
branch
from
October 27, 2026 22:30
b13fe0f to
76d531b
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294774
christophpurrer
force-pushed
the
export-D127294774
branch
from
October 27, 2026 23:07
76d531b to
92b3f24
Compare
Summary: The C++ bridge delegate protocol has no implementers left: its only method served the removed `RCTCxxBridge`. Delete the header with its build entry, the stale forward declaration, and the unused imports. Changelog: [iOS][Removed] - Remove unused `RCTCxxBridgeDelegate` protocol Differential Revision: D127294781
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Differential Revision: D127294783
Summary: Remove `RCTBridge` declarations with zero callers: `enqueueJSCall`, module lookup, `delegate`, `moduleClasses`, reload, and batch APIs, plus their stub implementations. Keep `bundleURL`, still read by Expo Dev Menu, and the TurboModule-registry hooks the proxy forwards through, all marked deprecated. Delete skipped `RCTLoggingTests`, the only `enqueueJSCall` caller. Changelog: [iOS][Removed] - Remove unused `RCTBridge` reload, module-lookup, and JS-callback APIs [iOS][Deprecated] - Deprecate `RCTBridge.bundleURL`, `setRCTTurboModuleRegistry:`, and `bridgeModuleDecorator` Differential Revision: D127265582
…59433) Summary: Pull Request resolved: react#59433 The `RCTTest` runner, `IntegrationTests` bundle, and `RNTesterIntegrationTests` target are fully disabled: every test is commented out or skipped for depending on the removed bridge. Delete the harness, the skipped `RCTDevMenuTests`/`RCTComponentPropsTests`/`RCTImageLoaderTests` class, and all project references. Changelog: [Internal] Differential Revision: D127294772
Summary: Both `RCTBridge` initializers return an inert stub and have no callers left now that the test harness is gone. Delete the declarations and stub implementations. `RCTBridgeModuleListProvider` stays until the proxy shim using it is removed. Changelog: [iOS][Removed] - Remove deprecated `RCTBridge` initializers Differential Revision: D127294773
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294774
christophpurrer
force-pushed
the
export-D127294774
branch
from
October 28, 2026 14:46
92b3f24 to
891b7da
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294774
christophpurrer
force-pushed
the
export-D127294774
branch
from
October 28, 2026 15:20
891b7da to
9ae8810
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Differential Revision: D127294774
Summary: Pull Request resolved: react#59435 The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294774
christophpurrer
force-pushed
the
export-D127294774
branch
from
October 28, 2026 15:49
9ae8810 to
3f171bc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The default JS executor factory unconditionally returns
nullptrand has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations.Changelog: [Internal]
Reviewed By: andrewdacenko
Differential Revision: D127294774