Skip to content

Only claim the TextInput responder while a touch is active #58477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Only claim the TextInput responder while a touch is active #58477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/react-native/Libraries/Components/TextInput/TextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,10 @@ type LastNativeSelection = {
mostRecentEventCount: number,
};

const emptyFunctionThatReturnsTrue = () => true;
// Claiming the responder on a selection change with no active touch leaves the
// input holding it with no matching touch event to release it.
const hasActiveTouch = (event: GestureResponderEvent) =>
event.touchHistory.numberActiveTouches > 0;

/**
* This hook handles the synchronization between the state of the text input
Expand Down Expand Up @@ -604,7 +607,7 @@ function InternalTextInput(props: TextInputProps): React.Node {
onFocus={_onFocus}
onScroll={_onScroll}
onSelectionChange={_onSelectionChange}
onSelectionChangeShouldSetResponder={emptyFunctionThatReturnsTrue}
onSelectionChangeShouldSetResponder={hasActiveTouch}
selection={selection}
selectionColor={selectionColor}
style={StyleSheet.compose(
Expand Down
Loading