Declare RNTester test pod dependencies for dynamic frameworks - #58471
Open
kunal26das wants to merge 1 commit into
Open
Declare RNTester test pod dependencies for dynamic frameworks#58471kunal26das wants to merge 1 commit into
kunal26das wants to merge 1 commit into
Conversation
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native stacked review: Review this layer in the registered six-PR fork stack. This PR remains the upstream submission to
react/react-native.RNTester's test pod uses
ObjCTurboModuleand the selected JavaScript engine but does not declare their providing pods as direct dependencies. When building RNTester from source with dynamic frameworks,React-RCTTestfails to link those symbols.Declare
React-NativeModulesAppleand use the existingdepend_on_js_enginehelper so CocoaPods links the selected engine. This is independent of the proposed Kotlin Multiplatform experiment; the dependency omission also reproduces in the generated source-build graph with KMP disabled.Changelog:
[INTERNAL] [FIXED] - Declare RNTester test pod dependencies for dynamic framework source builds.
Test Plan
The change is two dependency declarations; it changes no production implementation.