feat(a11y): automatically set accessible prop with role prop

[mdjastrzebski]

Summary:

Setting role prop (except none/presentation) automatically sets accessible prop on View and Image. This aligns web behavior when setting role attribute is enough to add the element into accessibility tree.

This aligns also with Image alt web-compat prop which also enables accessible when set.

The change skips Text, TextInput, etc as they are implicitly members of accessibility tree by default.

This change also intentionally skips accessibilityRole as legacy, non-web version.

This also helps when using React Strict DOM, as it exposes role prop, but does not expose accessible prop, hence setting role on h.div basically has no effect. I think this changes is better suited for RN repo though.

Changelog:

[GENERAL] [CHANGED] Automatically set acessible prop when role prop is set (except none/presenation)

Test Plan:

Added relevant Fantom tests.

[javache]

This seems reasonable, but is there any chance we can do this on the native side instead? We should avoid post-processing props in JS for perf reasons.

[mdjastrzebski]

@javache I did some research and it looks like C++ calculation would be fine for iOS, but on Android we need to have duplicated logic in Kotlin since the ViewManagers use the original JS rawProps, not the C++ derived values. Props 2.0 would solve it but it's not enabled atm.

Hence, I would advise to keep it in JS right now, and migrate multiple prop calculation from JS to C++ as a unified effort when Props 2.0 is available on Android.

[javache]

Extract accessible here (ditto for 'aria-label/accessibilityLabel) - we generally want to extract props once, and avoid passing them both in restProps` and through explicit props.

You'd want to model this like View where we create a single resolvedProps object which we write everything to.

Fine to do this as a follow-up cleanup PR, and overload this one.

[mdjastrzebski]

I will submit follow-up for not to muddle the scope

[meta-codesync]

@javache has imported this pull request. If you are a Meta employee, you can view this in D113754156.

[meta-codesync]

@javache merged this pull request in 4043e81.