Skip to content

Deploy 0.338.0 to xplat - #2139

Merged
meta-codesync[bot] merged 1 commit into
mainfrom
export-D128734618
Oct 31, 2026
Merged

meta-codesync[bot] merged 1 commit into
mainfrom
export-D128734618

Conversation

@SamChou19815

Copy link
Copy Markdown
Member

Summary:
changelog
Changelog: [Internal]

Reviewed By: gkz

Differential Revision: D128734618

Summary:
[changelog](https://github.com/facebook/flow/blob/main/Changelog.md)
Changelog: [Internal]

Reviewed By: gkz

Differential Revision: D128734618
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2026
@meta-codesync

meta-codesync Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128734618.

@github-actions

Copy link
Copy Markdown

Metro review: Looks good

Risk: low · Commit: 6a17428 · 3 commands run

This PR raises the root devDependency flow-bin and the .flowconfig version from 0.337 to 0.338. It also adds two $FlowFixMe[incompatible-type] suppressions to the Node Buffer libdef. Only dev tooling changes. No published package or runtime code changes. With Flow 0.338.0 installed, the head reports no Flow errors, and neither new suppression shows up as unused.

No findings.

Verified
  • ✅ node -p "require('flow-bin/package.json').version" (head) — 0.338.0 is installed, which matches the lockfile.
  • ✅ yarn flow check (head) — No errors.
  • ✅ yarn flow check --include-warnings --show-all-errors (head) — Neither new suppression in flow-typed/environment/node.js (lines 59 and 75) is reported as unused. The unused-suppression warnings that do appear are on other lines of the libdef, not ones this PR adds.

Not run: I tried to delete the two new suppressions to confirm Flow errors without them. The sandbox's permission policy blocked those edit-and-check commands, and the checkout is still clean. Because Flow reports neither suppression as unused, they are both suppressing a real error. I skipped benchmarks and Windows checks because this is a dev-only typechecker bump with no runtime effect. Changing package.json and yarn.lock needs a Meta import, but this PR came from Meta's monorepo in the first place.

Automated review by Claude. Advisory only: it never approves or blocks, and a maintainer makes the call.

@meta-codesync
meta-codesync Bot merged commit b8ac7a7 into main Oct 31, 2026
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported needs-meta-import

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant