Add AI upgrade prompt copy button#419
Add AI upgrade prompt copy button#419mym0404 wants to merge 4 commits intoreact-native-community:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
I know this repository has been inactive for a long while. |
|
hey folks - sorry, uber busy on my end. I'll write a note to self to check this one out later this week. thanks @mym0404 for the PR! I think it's probably a good one to add |
kelset
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR — sorry for the slow review on our side. I finally had a chance to go through it as part of a maintenance pass on the repo.
Overall, I think this is in good shape and the feature feels basically complete. The direction makes sense, the preview is useful, and I think this is a good addition for people using coding agents during upgrades.
Before we merge, there is one thing I think we should tighten up:
src/__tests__/Home.e2e.spec.tsadds a new screenshot assertion for the AI prompt button, but I don't see the matching committed baseline image undersrc/__tests__/__image_snapshots__/. Could you add the new snapshot asset (or adjust/remove that assertion if you want to test it another way)?
One smaller note that I don't consider blocking for merge: the new clipboard path uses navigator.clipboard.writeText(...) directly and doesn't yet have the fallback / feedback behavior that some of the other copy actions have. I'm okay treating that as follow-up polish if you'd prefer to keep this PR focused.
Once the screenshot-test piece is sorted out, I think this should be in a good place to land. Thanks again for putting this together.
Overview
resolve #410
resolve #415
Hello. Nowadays, I believe that people might haven't been able to find the time to make the RN version switch by hands.
I added a new Copy for AI button for them.
It looks like this and attached sample result at the bottom.
Results are fundamentally built from AI, but I reviewed it myself carefully.
Feel free to suggest your comments or improvements please. Have a good one.
Summary
Copy for AIaction next to the upgrade CTA after a diff is resolvedVerification
yarn lintyarn typecheckyarn testyarn buildResult (
0.80.0->0.85.1)Expand
React Native upgrade guidance request
You are helping upgrade a React Native app using the provided template diff.
Task overview
Important notes
Binary file handling
android/gradle/wrapper/gradle-wrapper.jarFile changes
package.jsonApp.tsxGemfileandroid/app/build.gradleandroid/app/src/debug/AndroidManifest.xmlandroid/app/src/main/AndroidManifest.xmlandroid/app/src/main/java/com/rndiffapp/MainApplication.ktandroid/build.gradleandroid/gradle.propertiesandroid/gradle/wrapper/gradle-wrapper.propertiesandroid/gradlewandroid/gradlew.batios/Podfileios/RnDiffApp.xcodeproj/project.pbxprojios/RnDiffApp/Info.plistjest.config.jstsconfig.json