refactor: remove fabricEnabled argument from DefaultReactActivityDelegate() call in MainActivity.kt since it is deprecated - #248
Merged
Conversation
zhang-brook
changed the title
createReactActivityDelegate() override in MainActivity.kt since it is not needed any morecreateReactActivityDelegate() override in MainActivity.kt since it is no longer needed
Member
|
We can remove the 3rd param, but not remove the override entirely, because the superclass has a different behavior: |
…gate The 3rd parameter is no longer required when constructing DefaultReactActivityDelegate. Keep the override itself to ensure proper React Native initialization.
zhang-brook
changed the title
createReactActivityDelegate() override in MainActivity.kt since it is no longer neededDefaultReactActivityDelegate() call in MainActivity.kt since it is deprecated
Contributor
Author
|
Thanks for the review @cortinico! Updated. |
cortinico
approved these changes
Aug 27, 2026
cipolleschi
reviewed
Sep 15, 2026
cipolleschi
left a comment
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
DefaultReactActivityDelegatenow only needs 2 parameters (activity,mainComponentName).The 3rd parameter has been marked as
@Suppress("UNUSED_PARAMETER"), so thecreateReactActivityDelegate()override in
MainActivity.ktis unnecessary boilerplate and can be safely removed from the template.Changelog:
[ANDROID] [CHANGED] - Remove
fabricEnabledargument fromDefaultReactActivityDelegateconstructor inMainActivity.ktsince it is deprecated