Skip to content

[Android] Fix variantPath for multiflavored paths #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Reeywhaar wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −2
Open

[Android] Fix variantPath for multiflavored paths #2762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3538dd9
Refactor variantPath creation for multiflavored paths
Reeywhaar Feb 3, 2026
dceebde
Fix TypeScript error with non-null assertion
Reeywhaar Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/cli-platform-android/src/commands/runAndroid/tryInstallAppOnDevice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ function tryInstallAppOnDevice(
.split(/(?=[A-Z])/);

// create path to output file, eg. `production/debug`
const variantPath =
variantFromSelectedTask?.join('/')?.toLowerCase() ?? defaultVariant;
// ensure multiflavored path is correct, e.g. `clientStagingDebug` -> `clientStaging/debug`
const variantPath = variantFromSelectedTask
? `${variantFromSelectedTask.slice(0, -1).join("")}/${variantFromSelectedTask.at(-1)!.toLocaleLowerCase()}`
: defaultVariant;
// create output file name, eg. `production-debug`
const variantAppName =
Copy link
Member

@cortinico cortinico Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be updated

Copy link
Author

@Reeywhaar Reeywhaar Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variantAppName? Seems to be fine

Copy link
Member

@cortinico cortinico Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Does it get generated as -client-staging-debug?

Copy link
Author

@Reeywhaar Reeywhaar Feb 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client-staging-debug to be precise. First dash prepended here. And that is correct, that is what gradle produces

variantFromSelectedTask?.join('-')?.toLowerCase() ?? defaultVariant;
Expand Down