Skip to content

fix: add jest resolver to fix unit tests #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azizbecha wants to merge 4 commits into
base: main
Choose a base branch
from
+451 −225
Open

fix: add jest resolver to fix unit tests #2761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
373232e
fix: add jest resolver to fix unit tests
azizbecha Jan 31, 2026
520947c
chore: lint
azizbecha Jan 31, 2026
6c0c731
chore: fix lint warnings
azizbecha Jan 31, 2026
e3a908a
chore: remove resolver
azizbecha Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __e2e__/default.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ afterEach(() => {
});

test('shows up help information without passing in any args', () => {
const {stderr} = runCLI(DIR);
const {stderr} = runCLI(DIR, [], {expectedFailure: true});
expect(stderr).toMatchSnapshot();
});

test('does not pass --platform-name by default', () => {
const {stderr} = runCLI(DIR);
const {stderr} = runCLI(DIR, [], {expectedFailure: true});
expect(stderr).not.toContain("unknown option '--platform-name'");
});
1 change: 1 addition & 0 deletions __e2e__/init.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ test('init supports --pm yarn together with --skip-install', () => {
});

// react-native-macos stopped shipping `template.config.js` for 0.75, so this test is disabled. in future releases we should re-enable once `template.config.js` will be there again.
// eslint-disable-next-line jest/no-disabled-tests
test.skip('init --platform-name should work for out of tree platform', () => {
createCustomTemplateFiles();
const outOfTreePlatformName = 'react-native-macos';
Expand Down
3 changes: 3 additions & 0 deletions jest/setupUnitTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// mock node: prefixed built-in modules for Jest 26 compatibility
jest.mock('node:zlib', () => require('zlib'), {virtual: true});
Copy link
Member

@thymikee thymikee Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a resolver if you mock the node:zlib like this?


jest.mock('@react-native-community/cli-tools', () => {
return {
...jest.requireActual('@react-native-community/cli-tools'),
Expand Down
4 changes: 2 additions & 2 deletions packages/cli-doctor/src/tools/healthchecks/androidStudio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ export default {
`studio${archSuffix}.exe`,
).replace(/\\/g, '\\\\');
try {
const {stdout} = await executeCommand(
const {stdout: fallbackStdout} = await executeCommand(
`wmic datafile where name="${fallbackPath}" get Version`,
);
version = stdout.replace(/(\r\n|\n|\r)/gm, '').trim();
version = fallbackStdout.replace(/(\r\n|\n|\r)/gm, '').trim();
Comment on lines +57 to +60
Copy link
Member

@thymikee thymikee Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary?

Copy link
Collaborator Author

@azizbecha azizbecha Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did that to solve prettier warning "'stdout' is already declared in the upper scope on line 34 column 14 @typescript-eslint/no-shadow"

} catch {
version = '';
}
Expand Down
4 changes: 3 additions & 1 deletion packages/cli-platform-apple/src/commands/runCommand/getBuildSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ export async function getBuildSettings(
.filter((setting: any) => setting.buildSettings.WRAPPER_EXTENSION === 'app')
.map(({target: settingsTarget}: any) => settingsTarget);

if (applicationTargets.length === 0) return null;
if (applicationTargets.length === 0) {
return null;
}

let selectedTarget = applicationTargets[0];

Expand Down
2 changes: 1 addition & 1 deletion packages/cli-server-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"dependencies": {
"@react-native-community/cli-tools": "20.1.1",
"body-parser": "^1.20.3",
"body-parser": "^2.2.2",
"compression": "^1.7.1",
"connect": "^3.6.5",
"errorhandler": "^1.5.1",
Expand Down
Loading
Loading