Skip to content

Fix CI breakage for ESLint 10 dependency bump#20

Merged
channel101 merged 2 commits intodependabot/npm_and_yarn/dev-deps-e8bd51b535from
copilot/sub-pr-19
Mar 9, 2026
Merged

Fix CI breakage for ESLint 10 dependency bump#20
channel101 merged 2 commits intodependabot/npm_and_yarn/dev-deps-e8bd51b535from
copilot/sub-pr-19

Conversation

Copy link
Contributor

Copilot AI commented Mar 9, 2026

The ESLint 10 Dependabot update broke CI before any job-specific work ran, and it also exposed an incompatibility in the repo’s flat ESLint setup for root config files. This PR updates the repo metadata and lint config so the dependency bump can run through the existing workflow again.

  • CI setup

    • Remove the stale Yarn release path from .yarnrc.yml so Node/npm setup no longer fails on a missing .yarn/releases/yarn-4.11.0.cjs.
    • Keep a valid packageManager in package.json, but point it at npm so Turbo can still resolve tasks in CI.
  • Dependency metadata

    • Sync package-lock.json with the bumped eslint / @eslint/js versions so npm ci matches package.json.
  • ESLint 10 compatibility

    • Scope the React Native legacy ESLint config to the TypeScript source tree instead of applying it to every *.js file in the repo.
    • Add explicit handling for root *.js and *.mjs config files using @eslint/js recommended rules plus the existing Prettier rule.
  • Config shape

    • The effective change is narrowing the legacy config and linting repo-level config files separately:
export default defineConfig([
  {
    files: ['src/**/*.{ts,tsx}'],
    extends: fixupConfigRules(compat.extends('@react-native', 'prettier')),
  },
  {
    ...js.configs.recommended,
    files: ['*.js'],
    languageOptions: { sourceType: 'commonjs' },
  },
  {
    ...js.configs.recommended,
    files: ['*.mjs'],
  },
]);

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: channel101 <202932523+channel101@users.noreply.github.com>
Copilot AI changed the title [WIP] Update dev-deps group with 2 updates Fix CI breakage for ESLint 10 dependency bump Mar 9, 2026
@channel101 channel101 marked this pull request as ready for review March 9, 2026 08:42
@channel101 channel101 merged commit 23728d4 into dependabot/npm_and_yarn/dev-deps-e8bd51b535 Mar 9, 2026
channel101 added a commit that referenced this pull request Mar 9, 2026
* chore(deps-dev): bump the dev-deps group with 2 updates

Bumps the dev-deps group with 2 updates: [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) and [eslint](https://github.com/eslint/eslint).


Updates `@eslint/js` from 9.39.4 to 10.0.1
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](https://github.com/eslint/eslint/commits/v10.0.1/packages/js)

Updates `eslint` from 9.39.4 to 10.0.3
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.39.4...v10.0.3)

---
updated-dependencies:
- dependency-name: "@eslint/js"
  dependency-version: 10.0.1
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: dev-deps
- dependency-name: eslint
  dependency-version: 10.0.3
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: dev-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix CI breakage for ESLint 10 dependency bump (#20)

* Initial plan

* fix ci for eslint 10 workflow run

Co-authored-by: channel101 <202932523+channel101@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: channel101 <202932523+channel101@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: channel101 <202932523+channel101@users.noreply.github.com>
@channel101 channel101 deleted the copilot/sub-pr-19 branch March 9, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants