Remove legacy PortalWrapper#780
Conversation
|
@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (3)
Walkthrough该 PR 完整移除了 Changes移除 PortalWrapper 模块
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/Portal.tsxESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. src/index.tsESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. tests/Portal.test.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request removes the PortalWrapper component, along with its associated demo, tests, and references. The GetContainer type, previously exported from PortalWrapper, is now defined and exported directly from src/index.ts. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #780 +/- ##
==========================================
- Coverage 86.42% 85.78% -0.64%
==========================================
Files 39 38 -1
Lines 1068 964 -104
Branches 388 332 -56
==========================================
- Hits 923 827 -96
+ Misses 143 135 -8
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
背景
PortalWrapper是早期 portal/body scroll lock 逻辑遗留下来的辅助组件。当前 Ant Design v6 相关链路已不再运行时使用该组件,下游@rc-component/dialog也已在 react-component/dialog#565 中将GetContainer类型改为从@rc-component/utilroot 导入。改动内容
PortalWrapper组件及其文档示例。GetContainer类型直接保留在src/index.ts中导出。Portal相关测试,仅保留Portal本体行为覆盖。Portal中遗留注释,移除对PortalWrapper的引用。验证
npm test -- Portal.test.tsxnpm run lint(仅保留既有 warning)npm run compile(仅保留既有 warning)npm testgit diff --checkSummary by CodeRabbit
发布说明
重构
文档
测试