Skip to content

refactor: Optimizing access to header values in default request #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: Optimizing access to header values in default request #430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f18fbf
refactor: Optimizing access to header values in default request
winie Jul 9, 2022
6be7fba
fix: Removes the unused parameter "header" when filtering headers wit…
winie Jul 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,18 @@ export default function upload(option: UploadRequestOption) {
const formData = new FormData();

if (option.data) {
Object.keys(option.data).forEach(key => {
const value = option.data[key];
Object.entries(option.data).forEach(([header, value]) => {
// support key-value array data
if (Array.isArray(value)) {
value.forEach(item => {
// { list: [ 11, 22 ] }
// formData.append('list[]', 11);
formData.append(`${key}[]`, item);
formData.append(`${header}[]`, item);
});
return;
}

formData.append(key, value as string | Blob);
formData.append(header, value as string | Blob);
});
}

Expand Down Expand Up @@ -91,11 +90,9 @@ export default function upload(option: UploadRequestOption) {
xhr.setRequestHeader('X-Requested-With', 'XMLHttpRequest');
}

Object.keys(headers).forEach(h => {
if (headers[h] !== null) {
xhr.setRequestHeader(h, headers[h]);
}
});
Object.entries(headers)
.filter(([, value]) => value !== null)
.forEach(([header, value]) => xhr.setRequestHeader(header, value));

xhr.send(formData);

Expand Down