fix: do not render collapsed row#979
Open
JordanDC2 wants to merge 3 commits intoreact-component:masterfrom
Open
fix: do not render collapsed row#979JordanDC2 wants to merge 3 commits intoreact-component:masterfrom
JordanDC2 wants to merge 3 commits intoreact-component:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #979 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 36 36
Lines 989 990 +1
Branches 305 320 +15
=======================================
+ Hits 984 985 +1
Misses 5 5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
related to #715 |
Member
|
Render using |
Member
|
Ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the case where you expand a table row which adds an element to the DOM, but previously would not be removed from the DOM when collapsing the row again.
This fix is useful for implementing zebra striping on a table with expandable rows, as without this fix, expanding a row and then collapsing it adds an invisible row which messes up striping.
close #714
close #715