[codex] support semantic notification slots#385
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
漫游通知组件新增 变更
代码审查工作量估计🎯 2 (简单) | ⏱️ ~12 分钟 建议的审查人员
诗
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 98.93% 98.96% +0.02%
==========================================
Files 13 13
Lines 1316 1352 +36
Branches 179 183 +4
==========================================
+ Hits 1302 1338 +36
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1ad8c6a to
4f0d2d0
Compare
There was a problem hiding this comment.
Code Review
This pull request enhances the Notification component by adding support for semantic styles and class names for the title, description, and actions elements. It updates the relevant interfaces, ensures these properties are correctly applied during rendering, and includes a comprehensive test case to validate the integration of global and local styles. I have no feedback to provide.
4f0d2d0 to
c946ec4
Compare
c946ec4 to
8c6316c
Compare
8c6316c to
ad4cf01
Compare
ad4cf01 to
6519731
Compare
6519731 to
ab193dd
Compare
ab193dd to
e890844
Compare
Summary
title,description, andactionssemantic slots to notification classNames/styles types.${noticePrefixCls}-actionsinstead of the bareactionsclass.Why
antd is moving notification content rendering into
@rc-component/notificationand needs these semantic slots to preserve its publicclassNames/stylesAPI during the migration.This keeps the existing icon wrapper slot behavior unchanged, so antd can continue passing its with-icon layout class through
classNames.wrapperwhen an icon exists. Role handling remains supported through existing rootprops.Validation
npm testnpm run lint(passes with existing hooks warnings)npm run compile(passes with existing hooks warnings)Summary by CodeRabbit
发布说明
新功能
role属性,增强无障碍访问支持,默认为alert。测试