Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projected Vertical Bars controls need their horizontal callout centered on the visible button. A boolean tied to the current 8px margin obscures the actual adjustment and is unsuitable if that margin changes.
This proposal adds a numeric
verticalOffsetanimation option, measured in CSS pixels. Omitting it usesPOPOVER_IOS_BODY_MARGIN; callers can explicitly pass0or another value. Replacing surfaces keep their existing positioning. No device detection or new viewport-clamping behavior is added.This replaces the reverted #7 and #8. The main branch was restored in 040f464; the already-published 0.1.3 package and tag remain published. This PR does not change versions or initiate a release.
Consumer proposal: ionic-theme-ios27 #258 passes
0only for horizontal popovers anchored to a projected Vertical Bar.Validation: all 20 unit tests and the TypeScript build pass. The offset regression covers omission, zero, positive and negative values. Consumer visual revalidation remains pending; this is a draft for design review.