RDKB-63406:Devicetype RFC default value is not migrating after software upgrade by NareshM1702 · Pull Request #212 · rdkcentral/utopia

NareshM1702 · 2026-02-09T06:27:18Z

Reason for change:clearing shellcheck errors in utopia components
Test Procedure: build and flash the image verify the RFC is changing
Risks:Medium
Priority: P1

Copilot

Pull request overview

This PR adds a one-time migration during boot to ensure the DeviceType syscfg value is set to PROD after a software/firmware upgrade (tracked via a new devicetype_migrate syscfg flag) for XB6 and HUB4 platforms.

Changes:

Add devicetype_migrate gating logic to run the migration only once after upgrade.
If migration hasn’t run yet, set DeviceType to PROD and persist the migration flag.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
source/scripts/init/system/utopia_init_xb6.sh	Adds one-time `DeviceType` migration logic gated by `devicetype_migrate`.
source/scripts/init/system/utopia_init_hub4.sh	Adds the same one-time `DeviceType` migration logic for HUB4.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-09T06:30:21Z

source/scripts/init/system/utopia_init_hub4.sh

+    echo "setting DeviceType to PROD"
+    syscfg set DeviceType "PROD"
+    syscfg commit
+  else
+    echo "DeviceType is already PROD, no change needed"
+  fi
+  syscfg set devicetype_migrate "1"
+  syscfg commit


syscfg commit is called twice in this migration path (once after setting DeviceType and again after setting devicetype_migrate). Consider setting both keys first and committing once to reduce persistent storage writes during boot.

Copilot · 2026-02-09T06:30:22Z

source/scripts/init/system/utopia_init_xb6.sh

   echo "SSH: Forward SSH changed to disabled" >> $Log_file
 fi

+#Change devicetype on firmware udgrade


Fix typos in the new migration header comment (e.g., "udgrade" -> "upgrade" and consider "device type" for readability).

Suggested change

#Change devicetype on firmware udgrade

# Change device type on firmware upgrade

Copilot · 2026-02-09T06:30:22Z

source/scripts/init/system/utopia_init_xb6.sh

+DEVICETYPE_MIGRATE="$(syscfg get devicetype_migrate)"
+echo "$DEVICETYPE_MIGRATE"
+if [ -z "$DEVICETYPE_MIGRATE" ]; then
+  CURRENT_DEVICETYPE="$(syscfg get DeviceType)"
+  echo "$CURRENT_DEVICETYPE"


The unconditional echo statements output raw syscfg values to stdout during init (including a blank line when unset). For XB6 this script already appends init/migration logs to $Log_file; consider removing these debug prints or logging with a consistent prefix and redirecting to the appropriate log file.

Copilot · 2026-02-09T06:30:22Z

source/scripts/init/system/utopia_init_xb6.sh

+    echo "setting DeviceType to PROD"
+    syscfg set DeviceType "PROD"
+    syscfg commit
+  else
+    echo "DeviceType is already PROD, no change needed"
+  fi
+  syscfg set devicetype_migrate "1"
+  syscfg commit


syscfg commit is called twice in this migration path (once after setting DeviceType and again after setting devicetype_migrate). To reduce flash/NVRAM writes, set both keys first and commit once at the end of the block.

Copilot · 2026-02-09T06:30:22Z

source/scripts/init/system/utopia_init_hub4.sh

   syscfg commit
 fi

+#Change devicetype on firmware udgrade


Fix typos in the new migration header comment (e.g., "udgrade" -> "upgrade" and consider "device type" for readability).

Suggested change

#Change devicetype on firmware udgrade

# Change device type on firmware upgrade

Copilot · 2026-02-09T06:30:23Z

source/scripts/init/system/utopia_init_hub4.sh

+DEVICETYPE_MIGRATE="$(syscfg get devicetype_migrate)"
+echo "$DEVICETYPE_MIGRATE"
+if [ -z "$DEVICETYPE_MIGRATE" ]; then
+  CURRENT_DEVICETYPE="$(syscfg get DeviceType)"
+  echo "$CURRENT_DEVICETYPE"


The unconditional echo statements print raw syscfg values to stdout during init (including a blank line when unset). Consider removing these debug prints or using the same tagged logging style used elsewhere in this script (e.g., echo "[utopia][init] ...").

…re upgrade

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T06:01:30Z

source/scripts/init/system/utopia_init_xb6.sh

   echo "SSH: Forward SSH changed to disabled" >> $Log_file
 fi

+#Change devicetype on firmware udgrade


Typo in comment: "udgrade" should be "upgrade".

Suggested change

#Change devicetype on firmware udgrade

#Change devicetype on firmware upgrade

Copilot · 2026-02-12T06:01:30Z

source/scripts/init/system/utopia_init_xb6.sh

+echo "$DEVICETYPE_MIGRATE"
+if [ -z "$DEVICETYPE_MIGRATE" ]; then
+  CURRENT_DEVICETYPE="$(syscfg get DeviceType)"
+  echo "$CURRENT_DEVICETYPE"


The two echo lines print raw syscfg values to stdout without any context/prefix, which can clutter boot logs and makes it hard to trace where the output came from. Consider removing these debug prints or logging with a consistent prefix (and/or redirecting to the existing $Log_file used in this section).

Suggested change

echo "$DEVICETYPE_MIGRATE"

if [ -z "$DEVICETYPE_MIGRATE" ]; then

CURRENT_DEVICETYPE="$(syscfg get DeviceType)"

echo "$CURRENT_DEVICETYPE"

echo "[utopia][init] devicetype_migrate value: $DEVICETYPE_MIGRATE" >> "$Log_file"

if [ -z "$DEVICETYPE_MIGRATE" ]; then

CURRENT_DEVICETYPE="$(syscfg get DeviceType)"

echo "[utopia][init] current DeviceType value: $CURRENT_DEVICETYPE" >> "$Log_file"

Copilot · 2026-02-12T06:01:31Z

source/scripts/init/system/utopia_init_xb6.sh

+    syscfg set DeviceType "PROD"
+    syscfg commit
+  else
+    echo "DeviceType is already PROD, no change needed"
+  fi
+  syscfg set devicetype_migrate "1"
+  syscfg commit


devicetype_migrate is set unconditionally after the DeviceType update attempt. If syscfg set/commit for DeviceType fails for any reason, the migrate flag will still be written and the script won’t retry on the next boot. Consider setting both keys and doing a single syscfg commit, and only marking devicetype_migrate=1 after confirming the DeviceType change (and commit) succeeded.

Suggested change

syscfg set DeviceType "PROD"

syscfg commit

else

echo "DeviceType is already PROD, no change needed"

fi

syscfg set devicetype_migrate "1"

syscfg commit

if syscfg set DeviceType "PROD" && syscfg set devicetype_migrate "1" && syscfg commit; then

echo "DeviceType successfully migrated to PROD and devicetype_migrate marked"

else

echo "Failed to migrate DeviceType to PROD; devicetype_migrate not marked (will retry on next boot)"

fi

else

echo "DeviceType is already PROD, no change needed"

if syscfg set devicetype_migrate "1" && syscfg commit; then

echo "devicetype_migrate successfully marked with existing PROD DeviceType"

else

echo "Failed to mark devicetype_migrate with existing PROD DeviceType (will retry on next boot)"

fi

fi

Copilot · 2026-02-12T06:01:31Z

source/scripts/init/system/utopia_init_hub4.sh

   syscfg commit
 fi

+#Change devicetype on firmware udgrade


Typo in comment: "udgrade" should be "upgrade".

Suggested change

#Change devicetype on firmware udgrade

#Change devicetype on firmware upgrade

Copilot · 2026-02-12T06:01:31Z

source/scripts/init/system/utopia_init_hub4.sh

+echo "$DEVICETYPE_MIGRATE"
+if [ -z "$DEVICETYPE_MIGRATE" ]; then
+  CURRENT_DEVICETYPE="$(syscfg get DeviceType)"
+  echo "$CURRENT_DEVICETYPE"


The two echo lines print raw syscfg values to stdout without any context/prefix, which can clutter boot logs and makes it hard to trace where the output came from. Consider removing these debug prints or logging with a consistent prefix (e.g., [utopia][init]).

Suggested change

echo "$DEVICETYPE_MIGRATE"

if [ -z "$DEVICETYPE_MIGRATE" ]; then

CURRENT_DEVICETYPE="$(syscfg get DeviceType)"

echo "$CURRENT_DEVICETYPE"

echo "[utopia][init] devicetype_migrate flag: $DEVICETYPE_MIGRATE"

if [ -z "$DEVICETYPE_MIGRATE" ]; then

CURRENT_DEVICETYPE="$(syscfg get DeviceType)"

echo "[utopia][init] Current DeviceType: $CURRENT_DEVICETYPE"

Copilot · 2026-02-12T06:01:31Z

source/scripts/init/system/utopia_init_hub4.sh

+    syscfg set DeviceType "PROD"
+    syscfg commit
+  else
+    echo "DeviceType is already PROD, no change needed"
+  fi
+  syscfg set devicetype_migrate "1"
+  syscfg commit


devicetype_migrate is set unconditionally after the DeviceType update attempt. If syscfg set/commit for DeviceType fails, the migrate flag will still be written and the script won’t retry on the next boot. Consider setting both keys and doing a single syscfg commit, and only marking devicetype_migrate=1 after confirming the DeviceType change (and commit) succeeded.

Suggested change

syscfg set DeviceType "PROD"

syscfg commit

else

echo "DeviceType is already PROD, no change needed"

fi

syscfg set devicetype_migrate "1"

syscfg commit

if syscfg set DeviceType "PROD" && syscfg set devicetype_migrate "1" && syscfg commit; then

echo "DeviceType updated to PROD and devicetype_migrate set"

else

echo "Failed to update DeviceType to PROD; devicetype_migrate not set" >&2

fi

else

echo "DeviceType is already PROD, no change needed"

if syscfg set devicetype_migrate "1" && syscfg commit; then

echo "devicetype_migrate set for existing PROD DeviceType"

else

echo "Failed to set devicetype_migrate for existing PROD DeviceType" >&2

fi

fi

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T06:23:48Z

source/scripts/init/system/utopia_init_xb6.sh


+#Change devicetype on firmware udgrade
+DEVICETYPE_MIGRATE="$(syscfg get devicetype_migrate)"
+echo "$DEVICETYPE_MIGRATE"


echo "$DEVICETYPE_MIGRATE" looks like leftover debug output and will print an empty line (or "1") to the console/log on every boot. Consider removing it or replacing it with a prefixed message that only logs when a migration is performed.

Suggested change

echo "$DEVICETYPE_MIGRATE"

Copilot · 2026-02-12T06:23:48Z

source/scripts/init/system/utopia_init_hub4.sh

+  echo "[utopia] Devicetype is $CURRENT_DEVICETYPE"
+  if [ "$CURRENT_DEVICETYPE" != "PROD" ]; then
+    echo "setting DeviceType to PROD"
+    syscfg set DeviceType "PROD"


Logging tag/format is inconsistent with the rest of this script (nearby messages use "[utopia][init]"), but this block uses "[utopia]" and unprefixed echos. Please align the log prefix/format so migration logs are searchable and consistent.

Copilot · 2026-02-12T06:23:48Z

source/scripts/init/system/utopia_init_xb6.sh

+  echo "[Utopia] Devicetype is $CURRENT_DEVICETYPE"
+  if [ "$CURRENT_DEVICETYPE" != "PROD" ]; then
+    echo "setting DeviceType to PROD"
+    syscfg set DeviceType "PROD"


Logging tag is inconsistent with the rest of this script (nearby messages use "[utopia][init]"), but this block uses "[Utopia]" and unprefixed echos. Please align the log prefix/format so migration logs are searchable and consistent.

Copilot · 2026-02-12T06:23:49Z

source/scripts/init/system/utopia_init_hub4.sh


+#Change devicetype on firmware udgrade
+DEVICETYPE_MIGRATE="$(syscfg get devicetype_migrate)"
+echo "$DEVICETYPE_MIGRATE"


echo "$DEVICETYPE_MIGRATE" looks like leftover debug output and will print an empty line (or "1") to the console/log on every boot. Consider removing it or replacing it with a prefixed message that only logs when a migration is performed.

Suggested change

echo "$DEVICETYPE_MIGRATE"

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-13T07:40:56Z

source/scripts/init/system/utopia_init.sh

   syscfg commit
 fi

+#Change devicetype on firmware udgrade


The comment contains a spelling error: "udgrade" should be "upgrade".

Suggested change

#Change devicetype on firmware udgrade

#Change devicetype on firmware upgrade

Copilot · 2026-02-13T07:40:57Z

source/scripts/init/system/utopia_init.sh

+  echo "[utopia] Devicetype is $CURRENT_DEVICETYPE"
+  if [ "$CURRENT_DEVICETYPE" != "PROD" ]; then
+    echo "setting DeviceType to PROD"
+    syscfg set DeviceType "PROD"


Missing syscfg commit after setting DeviceType to PROD. The pattern in this file (lines 434-436) shows that syscfg set operations should be followed by syscfg commit. Without the commit here, the DeviceType change may not be persisted. Add a syscfg commit after line 272.

Suggested change

syscfg set DeviceType "PROD"

syscfg set DeviceType "PROD"

syscfg commit

ManojU89

Changes looks good.Thanks

NareshM1702 requested review from a team as code owners February 9, 2026 06:27

Copilot AI review requested due to automatic review settings February 9, 2026 06:27

Copilot started reviewing on behalf of NareshM1702 February 9, 2026 06:27 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 12, 2026 05:57

NareshM1702 force-pushed the topic/RDKB-63406 branch from 8964ae6 to 9591b2c Compare February 12, 2026 05:57

Copilot started reviewing on behalf of NareshM1702 February 12, 2026 05:58 View session

NareshM1702 added 2 commits February 12, 2026 06:01

RDKB-63406:Devicetype RFC default value is not migrating after softwa…

4b02e64

…re upgrade

RDKB-63406:Devicetype RFC default value is not migrating after softwa…

e941e3b

…re upgrade

NareshM1702 force-pushed the topic/RDKB-63406 branch from 9591b2c to e941e3b Compare February 12, 2026 06:01

Copilot AI reviewed Feb 12, 2026

View reviewed changes

NareshM1702 added 2 commits February 12, 2026 11:48

Update utopia_init_xb6.sh

4b79d77

Update utopia_init_hub4.sh

b81534d

Copilot AI review requested due to automatic review settings February 12, 2026 06:19

Copilot started reviewing on behalf of NareshM1702 February 12, 2026 06:20 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

NareshM1702 added 2 commits February 12, 2026 14:48

Update utopia_init.sh

241b9eb

Update utopia_init.sh

a0bcd7e

Copilot AI review requested due to automatic review settings February 13, 2026 07:37

Copilot started reviewing on behalf of NareshM1702 February 13, 2026 07:37 View session

NareshM1702 added 2 commits February 13, 2026 13:07

Update utopia_init_xb6.sh

41aa3fe

Update utopia_init_hub4.sh

74cd250

Copilot AI reviewed Feb 13, 2026

View reviewed changes

ManojU89 approved these changes Feb 13, 2026

View reviewed changes

	#Change devicetype on firmware udgrade
	# Change device type on firmware upgrade

	#Change devicetype on firmware udgrade
	#Change devicetype on firmware upgrade

	syscfg set DeviceType "PROD"
	syscfg set DeviceType "PROD"
	syscfg commit

Conversation

NareshM1702 commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

ManojU89 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

NareshM1702 commented Feb 9, 2026 •

edited

Loading