RDK-60312: Log level modifications for curl communication logs#262
RDK-60312: Log level modifications for curl communication logs#262yogeswaransky wants to merge 6 commits intodevelopfrom
Conversation
Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
There was a problem hiding this comment.
Pull request overview
This pull request modifies log levels for curl communication logs in the telemetry component to reduce log verbosity. The changes downgrade several informational success messages from T2Info to T2Debug level while keeping error messages at T2Error level. Additionally, the PR includes comment refinements and clarifications throughout the HTTP connection pool implementation.
Changes:
- Downgraded success log messages from T2Info to T2Debug in HTTP GET/POST operations
- Updated and clarified comments throughout the connection pool implementation
- Simplified log messages by removing redundant phrases like "using connection pool"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| source/xconf-client/xconfclient.c | Changed HTTP GET success log from T2Info to T2Debug; simplified error message |
| source/protocol/http/multicurlinterface.c | Multiple log level adjustments, comment refinements, and clarifications for connection pool operations |
| source/protocol/http/curlinterface.c | Changed HTTP POST success log from T2Info to T2Debug; simplified error message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Check environment variable T2_CONNECTION_POOL_SIZE to have the size | ||
| // of the connection pool based on the device type |
There was a problem hiding this comment.
The comment style is inconsistent here. Line 106-107 has a multi-line comment using "// ... // ..." format which is uncommon. It would be more conventional to either use a single-line comment or a block comment with proper indentation. Consider rewording as a single line: "// Check environment variable T2_CONNECTION_POOL_SIZE for device-specific pool size"
| // Check environment variable T2_CONNECTION_POOL_SIZE to have the size | |
| // of the connection pool based on the device type | |
| // Check environment variable T2_CONNECTION_POOL_SIZE for device-specific pool size |
1 participant
No description provided.