Skip to content

chore(proto): pull the soft-delete check RPCs and organization resources - #1930

Merged
AmanGIT07 merged 1 commit into
mainfrom
chore/bump-proton-soft-delete-rpcs
Sep 17, 2026
Merged

chore(proto): pull the soft-delete check RPCs and organization resources#1930
AmanGIT07 merged 1 commit into
mainfrom
chore/bump-proton-soft-delete-rpcs

Conversation

@AmanGIT07

@AmanGIT07 AmanGIT07 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Pins PROTON_COMMIT to raystack/proton main at 680ef693 (raystack/proton#503) and regenerates proto/v1beta1. No handler logic changes.

Changes

  • New RPCs in the generated FrontierService: CheckProjectDelete, CheckCurrentUserDelete, DeleteCurrentUser, CreateOrganizationResource, UpdateOrganizationResource, DeleteOrganizationResource. None has a handler yet; the authorization interceptor denies them by default.
  • Blocker is now a top-level message shared by every check RPC, with a new count field. CheckOrganizationDelete builds frontierv1beta1.Blocker in place of the removed nested type. Wire format and JSON are unchanged.
  • Resource gains org_id.
  • CreateOrganizationResourceRequest, UpdateOrganizationResourceRequest, and DeleteOrganizationResourceRequest require org_id to be a uuid.

Test Plan

  • go build ./... and go vet ./...
  • go test -race ./internal/api/v1beta1connect/... ./pkg/server/... ./core/deleter/...
  • make lint
  • make proto at the merged commit produces the same files as at the PR head commit

@AmanGIT07
chore(proto): pull the soft-delete check RPCs and organization resources
1deb378 
Pins proton to 680ef693 and regenerates. The generated code gains
CheckProjectDelete, CheckCurrentUserDelete, DeleteCurrentUser, and
Create/Update/DeleteOrganizationResource, the shared Blocker message with
count, and Resource.org_id. The org delete handler uses the new Blocker
type.
@vercel

vercel Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
frontier Ready Ready Preview Sep 17, 2026 6:32am UTC

@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b3d084ed-dbd5-42c2-8bc8-c0d22bdde22a

📥 Commits

Reviewing files that changed from the base of the PR and between f3f2094 and 1deb378.

⛔ Files ignored due to path filters (3)
  • proto/v1beta1/frontier.pb.go is excluded by !**/*.pb.go, !proto/**
  • proto/v1beta1/frontierv1beta1connect/frontier.connect.go is excluded by !proto/**
  • proto/v1beta1/models.pb.go is excluded by !**/*.pb.go, !proto/**
📒 Files selected for processing (2)
  • Makefile
  • internal/api/v1beta1connect/deleter.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

📝 Summary

Summary by CodeRabbit

  • Chores

    • Updated the source revision used when generating protobuf files.

  • Bug Fixes

    • Improved consistency in organization deletion checks while preserving existing blocker details and response behavior.

Walkthrough

The change updates the pinned Proton revision used for protobuf generation and changes organization deletion checks to use the shared frontierv1beta1.Blocker type.

Changes

Protobuf revision

Layer / File(s) Summary
Update Proton generation revision
Makefile		 The proto target now uses Proton commit 680ef693ec1059e996f6a92e6936a56d1a8ac1cd.

Organization deletion blocker type

Layer / File(s) Summary
Use shared blocker type
internal/api/v1beta1connect/deleter.go		 CheckOrganizationDelete now constructs blockers with frontierv1beta1.Blocker.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: whoabhisheksah

Merge Risk: ⚪ Minimal · up to 1deb3

The shared blocker conversion preserves all available service data, so no actionable merge risk remains.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

coveralls commented Sep 17, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 35190254543

Coverage remained the same at 50.229%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats

Coverage Status
Relevant Lines: 41106
Covered Lines: 20647
Line Coverage: 50.23%
Coverage Strength: 16.01 hits per line
💛 - Coveralls

@AmanGIT07
AmanGIT07 merged commit e17b050 into main Sep 17, 2026
8 checks passed
@AmanGIT07
AmanGIT07 deleted the chore/bump-proton-soft-delete-rpcs branch September 17, 2026 06:43

This branch was successfully deployed

1 active deployment
Preview — 1deb378a Deployed Sep 17, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohilsurana rohilsurana rohilsurana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AmanGIT07 @coveralls @rohilsurana