Skip to content

chore: remove projects column from service accounts table #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 2 commits into from
Apr 30, 2026
Merged

chore: remove projects column from service accounts table #1589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52372a2
chore: remove project column from service account
rohanchkrabrty Apr 30, 2026
916773d
Merge branch 'main' into remove-service-page
rohanchkrabrty Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions web/sdk/react/views-new/service-accounts/components/projects-cell.module.css
View file
Open in desktop

This file was deleted.

56 changes: 0 additions & 56 deletions web/sdk/react/views-new/service-accounts/components/projects-cell.tsx
View file
Open in desktop

This file was deleted.

19 changes: 1 addition & 18 deletions web/sdk/react/views-new/service-accounts/components/service-account-columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {
import type { ServiceUser } from '@raystack/proton/frontier';
import type { Timestamp } from '@bufbuild/protobuf/wkt';
import { timestampToDayjs } from '~/utils/timestamp';
import { ProjectsCell } from './projects-cell';
import styles from './service-account-columns.module.css';

export interface ServiceAccountMenuPayload {
Expand All @@ -26,14 +25,12 @@ interface GetColumnsOptions {
dateFormat: string;
menuHandle: MenuHandle;
canUpdateWorkspace: boolean;
orgId: string;
}

export const getColumns = ({
dateFormat,
menuHandle,
canUpdateWorkspace,
orgId
canUpdateWorkspace
}: GetColumnsOptions): DataTableColumnDef<ServiceUser, unknown>[] => [
{
header: 'Name',
Expand All @@ -43,20 +40,6 @@ export const getColumns = ({
return <Text size="regular">{value}</Text>;
}
},
{
header: 'Projects',
id: 'projects',
accessorKey: 'id',
enableSorting: false,
styles: {
cell: { maxWidth: '600px' },
header: { maxWidth: '600px' }
},
cell: ({ getValue }) => {
const serviceUserId = getValue() as string;
return <ProjectsCell serviceUserId={serviceUserId} orgId={orgId} />;
}
},
{
header: 'Created On',
accessorKey: 'createdAt',
Expand Down
5 changes: 2 additions & 3 deletions web/sdk/react/views-new/service-accounts/service-accounts-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,9 @@ export function ServiceAccountsView({
getColumns({
dateFormat,
menuHandle: serviceAccountMenuHandle,
canUpdateWorkspace,
orgId
canUpdateWorkspace
}),
[dateFormat, canUpdateWorkspace, orgId]
[dateFormat, canUpdateWorkspace]
);

const handleCreated = (serviceUserId: string) => {
Expand Down
Loading