Repository navigation
Conversation
The chip seeded its operator from the first entry of its list, so a restored filter rendered the wrong operator while the rows were filtered by the real one. FilterChip now takes an operation prop, and DataTable and DataView pass the operator the query carries.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
commit: |
rsbh
requested review from
Shreyag02 and
rohanchkrabrty
and removed request for
rohanchkrabrty
November 6, 2026 07:38
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterChipseeded its operator from the first entry of its list, so a restored filter showed the wrong operator while the rows were filtered by the real one.FilterChiptakes anoperationprop, the active operator by itsvalue. A value the list does not have falls back to the first one.DataTable and DataView pass the operator the query carries, so changing it in the chip and reading it back stay in step.
Tests cover the chip prop and a restored
neqfilter in both DataTable and DataView.I have followed the pull request section of the contributing guide.