-
Notifications
You must be signed in to change notification settings - Fork 7k
feat: Added RunLLM chat widget for Ray docs; disabled regular AI chatbot #59126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Christina Zhu <christina@anyscale.com>
Signed-off-by: Christina Zhu <christina@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the RunLLM chat widget to the Ray documentation, replacing the previous 'Ask AI' chatbot. The changes involve adding a new JavaScript file to dynamically load the widget, and updating the Sphinx configuration to include this new script while disabling the old one. The implementation is mostly correct, but I've identified a few areas for improvement in the new JavaScript file concerning best practices, correctness, and maintainability. Specifically, I've suggested using const over var, correcting an invalid attribute value for crossorigin, extracting a magic number into a constant, and simplifying the script by removing a redundant event listener.
Signed-off-by: Christina Zhu <christina@anyscale.com>
|
@cristianjd @maxpumperla Just saw you two worked on the last version of Ask AI so requested a review! Msg me if you have any questions :) |
crypdick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamp
Signed-off-by: Christina Zhu <christina@anyscale.com>
19bd9cc to
6ee3925
Compare
Description
This PR integrates the runLLM chat widget into the Ray documentation site, replacing the existing custom "Ask AI" widget. Our new widget appears in the bottom-left corner of all doc pages and will answer questions powered by our runLLM agent.
Changes:
runllm-widget.jsto load and configure the runLLM widgetconf.pyto include the widget script on all pagesRelated issues
N/A - New feature addition
Additional information
Testing:
DOC_LIB=data sphinx-build -b html -d _build/doctrees source _build/htmlpython -m http.server 8000 -d _build/htmlScreenshots:


Examples of the widget on various pages:
Example of widget open (opens an overlay):

The existing custom "Ask AI" widget has been disabled but the code remains commented out in case we need to revert.